-
Notifications
You must be signed in to change notification settings - Fork 457
MCO-1624: Make MCN e2e tests blocking #4972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCO-1624: Make MCN e2e tests blocking #4972
Conversation
|
@isabella-janssen: This pull request references MCO-1624 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
@isabella-janssen: This pull request references MCO-1624 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@isabella-janssen: This pull request references MCO-1624 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-gcp-op |
|
/hold Holding this PR as these tests will not successfully pass in the standard e2e test suite until the feature gate graduates to default for MCN. |
|
/test ? |
|
@isabella-janssen: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-ci-openshift-machine-config-operator-main-e2e-hypershift-techpreview |
|
@isabella-janssen: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-hypershift-techpreview |
…t of the blocking test suite
cc20a92 to
0fa2e3e
Compare
|
/test e2e-gcp-op |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-gcp-op |
|
/retest-required |
|
/unhold The MCN feature gate graduated in 4.20 (openshift/api#2288), so this PR is no longer blocked. |
|
/lgtm This will likely fail on gcp-op for now. These tests are pretty fast IIRC, so we probably don't need a bump to the timeout, correct? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@djoshy The scope tests are definitely quick! There's one that was added with the custom MCP support ( Detailed:
|
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
c86a9b0
into
openshift:main
- What I did
Moved MCN e2e tests from non-blocking
e2e-techpreviewsuite to blockinge2esuite.- How to verify it
Run e2e tests with
/test e2e-gcp-op.- Description for the changelog
MCO-1624: Move MCN e2e tests into
e2esuite.