Skip to content

Conversation

@isabella-janssen
Copy link
Member

@isabella-janssen isabella-janssen commented Apr 4, 2025

- What I did
Moved MCN e2e tests from non-blocking e2e-techpreview suite to blocking e2e suite.

- How to verify it
Run e2e tests with /test e2e-gcp-op.

- Description for the changelog
MCO-1624: Move MCN e2e tests into e2e suite.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025

@isabella-janssen: This pull request references MCO-1624 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did
Moved MCN e2e tests from non-blocking e2e-techpreview suite to blocking e2e suite.

- How to verify it
Run e2e tests.

- Description for the changelog
MCO-1624: Move MCN e2e tests into e2e suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025

@isabella-janssen: This pull request references MCO-1624 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did
Moved MCN e2e tests from non-blocking e2e-techpreview suite to blocking e2e suite.

- How to verify it
Run e2e tests.

- Description for the changelog
MCO-1624: Move MCN e2e tests into e2e suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 4, 2025

@isabella-janssen: This pull request references MCO-1624 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

- What I did
Moved MCN e2e tests from non-blocking e2e-techpreview suite to blocking e2e suite.

- How to verify it
Run e2e tests with /test e2e-gcp-op.

- Description for the changelog
MCO-1624: Move MCN e2e tests into e2e suite.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

/test e2e-gcp-op

@isabella-janssen isabella-janssen marked this pull request as ready for review April 7, 2025 17:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2025
@openshift-ci openshift-ci bot requested review from cheesesashimi and djoshy April 7, 2025 17:31
@isabella-janssen
Copy link
Member Author

/hold

Holding this PR as these tests will not successfully pass in the standard e2e test suite until the feature gate graduates to default for MCN.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2025
@isabella-janssen
Copy link
Member Author

/test ?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@isabella-janssen: The following commands are available to trigger required jobs:

/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op
/test e2e-gcp-op-single-node
/test e2e-hypershift
/test images
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test bootstrap-unit
/test e2e-agent-compact-ipv4
/test e2e-aws-disruptive
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-fips-op
/test e2e-aws-ovn-ocb-techpreview
/test e2e-aws-ovn-upgrade-ocb-techpreview
/test e2e-aws-ovn-upgrade-out-of-change
/test e2e-aws-ovn-windows
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-single-node
/test e2e-aws-upgrade-single-node
/test e2e-aws-workers-rhel8
/test e2e-azure
/test e2e-azure-ovn-upgrade
/test e2e-azure-ovn-upgrade-out-of-change
/test e2e-azure-upgrade
/test e2e-gcp-op-ocl
/test e2e-gcp-op-techpreview
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-rt
/test e2e-gcp-rt-op
/test e2e-gcp-single-node
/test e2e-gcp-upgrade
/test e2e-hypershift-techpreview
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-dualstack
/test e2e-openstack-externallb
/test e2e-openstack-hypershift
/test e2e-openstack-parallel
/test e2e-openstack-singlestackv6
/test e2e-ovirt
/test e2e-ovirt-upgrade
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-ovn-upi
/test e2e-vsphere-ovn-upi-zones
/test e2e-vsphere-ovn-zones
/test e2e-vsphere-upgrade
/test okd-e2e-aws
/test okd-e2e-gcp-op
/test okd-e2e-upgrade
/test okd-e2e-vsphere
/test okd-images
/test okd-scos-e2e-aws-ovn
/test okd-scos-images
/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-config-operator-main-bootstrap-unit
pull-ci-openshift-machine-config-operator-main-e2e-agent-compact-ipv4
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-windows
pull-ci-openshift-machine-config-operator-main-e2e-azure-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-single-node
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-techpreview
pull-ci-openshift-machine-config-operator-main-e2e-hypershift
pull-ci-openshift-machine-config-operator-main-e2e-hypershift-techpreview
pull-ci-openshift-machine-config-operator-main-images
pull-ci-openshift-machine-config-operator-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-main-security
pull-ci-openshift-machine-config-operator-main-unit
pull-ci-openshift-machine-config-operator-main-verify
pull-ci-openshift-machine-config-operator-main-verify-deps

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Member Author

/test pull-ci-openshift-machine-config-operator-main-e2e-hypershift-techpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2025

@isabella-janssen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op
/test e2e-gcp-op-single-node
/test e2e-hypershift
/test images
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test bootstrap-unit
/test e2e-agent-compact-ipv4
/test e2e-aws-disruptive
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-fips-op
/test e2e-aws-ovn-ocb-techpreview
/test e2e-aws-ovn-upgrade-ocb-techpreview
/test e2e-aws-ovn-upgrade-out-of-change
/test e2e-aws-ovn-windows
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-single-node
/test e2e-aws-upgrade-single-node
/test e2e-aws-workers-rhel8
/test e2e-azure
/test e2e-azure-ovn-upgrade
/test e2e-azure-ovn-upgrade-out-of-change
/test e2e-azure-upgrade
/test e2e-gcp-op-ocl
/test e2e-gcp-op-techpreview
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-rt
/test e2e-gcp-rt-op
/test e2e-gcp-single-node
/test e2e-gcp-upgrade
/test e2e-hypershift-techpreview
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-dualstack
/test e2e-openstack-externallb
/test e2e-openstack-hypershift
/test e2e-openstack-parallel
/test e2e-openstack-singlestackv6
/test e2e-ovirt
/test e2e-ovirt-upgrade
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-ovn-upi
/test e2e-vsphere-ovn-upi-zones
/test e2e-vsphere-ovn-zones
/test e2e-vsphere-upgrade
/test okd-e2e-aws
/test okd-e2e-gcp-op
/test okd-e2e-upgrade
/test okd-e2e-vsphere
/test okd-images
/test okd-scos-e2e-aws-ovn
/test okd-scos-images
/test security

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-machine-config-operator-main-bootstrap-unit
pull-ci-openshift-machine-config-operator-main-e2e-agent-compact-ipv4
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-main-e2e-aws-ovn-windows
pull-ci-openshift-machine-config-operator-main-e2e-azure-ovn-upgrade-out-of-change
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-ocl
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-single-node
pull-ci-openshift-machine-config-operator-main-e2e-gcp-op-techpreview
pull-ci-openshift-machine-config-operator-main-e2e-hypershift
pull-ci-openshift-machine-config-operator-main-e2e-hypershift-techpreview
pull-ci-openshift-machine-config-operator-main-images
pull-ci-openshift-machine-config-operator-main-okd-scos-e2e-aws-ovn
pull-ci-openshift-machine-config-operator-main-security
pull-ci-openshift-machine-config-operator-main-unit
pull-ci-openshift-machine-config-operator-main-verify
pull-ci-openshift-machine-config-operator-main-verify-deps

In response to this:

/test pull-ci-openshift-machine-config-operator-main-e2e-hypershift-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Member Author

/test e2e-hypershift-techpreview

@isabella-janssen isabella-janssen force-pushed the mco-1624-mcnBlockingTests branch from cc20a92 to 0fa2e3e Compare May 19, 2025 16:07
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 19, 2025
@isabella-janssen
Copy link
Member Author

/test e2e-gcp-op

@isabella-janssen
Copy link
Member Author

/retest-required

1 similar comment
@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/test e2e-gcp-op

@isabella-janssen
Copy link
Member Author

/retest-required

@isabella-janssen
Copy link
Member Author

/unhold

The MCN feature gate graduated in 4.20 (openshift/api#2288), so this PR is no longer blocked.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2025
@djoshy
Copy link
Contributor

djoshy commented Jun 27, 2025

/lgtm

This will likely fail on gcp-op for now. These tests are pretty fast IIRC, so we probably don't need a bump to the timeout, correct?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen
Copy link
Member Author

isabella-janssen commented Jun 27, 2025

These tests are pretty fast IIRC, so we probably don't need a bump to the timeout, correct?

@djoshy The scope tests are definitely quick! There's one that was added with the custom MCP support (TestMCNPoolNameCustom) that took 46 sec on the last successful run. I think with these taking less than 1 minute total we won't need a timeout bump, but willing to do so if you think that's needed.

Detailed:

  • TestMCNScopeSadPath | 1s
  • TestMCNScopeImpersonationPath | 0s
  • TestMCNScopeHappyPath | 1s
  • TestMCNPoolNameDefault | 0s
  • TestMCNPoolNameCustom | 46s

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 36a1298 and 2 for PR HEAD 0fa2e3e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD a08d5ec and 1 for PR HEAD 0fa2e3e in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 28, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 0fa2e3e link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-hypershift-techpreview 0fa2e3e link false /test e2e-hypershift-techpreview
ci/prow/e2e-gcp-op-ocl 0fa2e3e link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD febcfba and 0 for PR HEAD 0fa2e3e in total

@openshift-merge-bot openshift-merge-bot bot merged commit c86a9b0 into openshift:main Jun 28, 2025
17 of 20 checks passed
@isabella-janssen isabella-janssen deleted the mco-1624-mcnBlockingTests branch October 17, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants