MCO-1524: Promote PinnedImageSet feature gate to default feature set

[RishabhSaini]

features: Lift feature gate for PIS

[openshift-ci]

Hello @RishabhSaini! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@RishabhSaini: This pull request references MCO-1524 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

features: Lift feature gate for PIS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[RishabhSaini]

/test verify-feature-promotion

[JoelSpeed]

/retest

[isabella-janssen]

/hold

This depends on the GA of the MachineConfigNode feature (#2288).

[RishabhSaini]

/test verify-feature-promotion

[yuqi-zhang]

/hold cancel

#2288 has merged and this can go ahead. Note that much like #2288 (comment) , the test names were changed.

The failures in verify-crd-schema seem to be related to legacy MCP fields since this changes that API. Perhaps we should override that since we don't want to change any legacy fields in this PR?

[JoelSpeed]

Reviewing the promotion results, since the tests were renamed, we have the 14 required runs and there have been no failures, showing 100% across the board. Taking into account the renames, the worst pass rate is 94%, but since these results are older than a week, we can discount these failures now

/lgtm
/override ci/prow/verify-feature-promotion
/override ci/prow/verify-crd-schema

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, RishabhSaini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-feature-promotion

In response to this:

Reviewing the promotion results, since the tests were renamed, we have the 14 required runs and there have been no failures, showing 100% across the board. Taking into account the renames, the worst pass rate is 94%, but since these results are older than a week, we can discount these failures now

/lgtm
/override ci/prow/verify-feature-promotion
/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@RishabhSaini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial	a25a302	link	true	/test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview	a25a302	link	true	/test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.