This repository was archived by the owner on Mar 17, 2020. It is now read-only.
Move administrator login to the current page object pattern #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
javigomez
commented
Jun 30, 2016
javigomez
commented
- Move login Step and Page to the current Architecture Tests pattern that we are following
- Update Content and Users to the changes in login step object
- Implement "joomla is installed" step to check if joomla has a configuration.php file
| <?php echo JText::_('JGLOBAL_USERNAME'); ?> | ||
| </label> | ||
| </span> | ||
| <input name="username" tabindex="1" id="mod-login-username" type="text" class="input-medium" placeholder="<?php echo JText::_('JGLOBAL_USERNAME'); ?>" size="15" autofocus="true" data-tests="username"/> |
There was a problem hiding this comment.
I'm removing this HTML5 attribute that was added with this idea: joomla/joomla-cms#10589
But the current agreement is that we are not going to use this attributes unless is really needed. So for the moment we will use the existing IDs for locating the elements and use the AdministratorLogin Page Object to store the locators.
|
|
||
| /** | ||
| * @Then I should see the administrator dashboard | ||
| * @When I see the administrator dashboard |
There was a problem hiding this comment.
We could add a regex here or just add the two gherkin sentences that will call the Step method. See: http://codeception.com/docs/07-BDD#step-definitions
I took the option of adding the two sentences.
|
@javigomez this PR was not possible to run directly. So, I have add some code changes based on my above comments here javigomez#2 |
# Conflicts: # tests/_support/Page/Acceptance/Administrator/LoginPage.php
|
Thank you @javigomez |
yvesh
pushed a commit
that referenced
this pull request
Jun 17, 2017
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.