This repository was archived by the owner on Mar 17, 2020. It is now read-only.
Fix the issue_#30 #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class UserGroupPage extends AdminPage | ||
| { | ||
| // include url of current page | ||
| public static $groupPageURL = 'administrator/index.php?option=com_users&view=groups'; |
There was a problem hiding this comment.
This sound redundant:
$I->amOnPage(UserGroupPage::$groupPageURL);
What about?
$I->amOnPage(UserGroupPage::$url);
that way we have a standard: every page object will have the $url property
There was a problem hiding this comment.
Yeah, it's good idea.I will implement it.
|
Merging and creating a new issue for improvements |
yvesh
pushed a commit
to yvesh/gsoc16_browser-automated-tests
that referenced
this pull request
Aug 16, 2016
* Initial test environment setup with Jasmine, Karma and RequireJS * Seperated test setup code from test logic * Configured .travis.yml to run Karma * Fixed typo in .travis.yml * changes to .travis.yml * Added karma requirejs module * Removed unnecessary code in travis.yml * Fixed missing code is travis.yml * Removed 2 unused image files * Improved code standards * Modified travis.yml * Issue 1 Cleaned the mess with changes bunch of to unrelated files * Issue 1 Added newline at end of file * Issue 4 Improved JCaption JavaScript tests * New coeverage reporter plugin test with Travis * Issue 1 Added karma-coerage reporter and configured it to display coverage on console * Issue 1 Added and configured karma-verbose-reporter plugin * Issue 1 Fixing verbose reporter config for travis * Issue 1 removed redundant javascript dir and added requirejs/text plugin to load fixtures * Issue 4 Improved code with suggestions made in the code review * Issue 1 Added version for requirejs text plugin * Issue 1 converted space indentations to tabs * Issue 1 Fixed indentation in package.json * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 1 Fixed version issue in require text * Issue 4 Improved code standards and jquer selector efficiency * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Tersting version issue with text plugin on travis * Issue 1 Removed spec folder * Corejs tests (joomla-projects#15) Tests for core.js * Tests for permissions.js (joomla-projects#13) * Test suite for permissions.js * Added karma-jasmine-ajax plugin * Added a container div for fixtures representing library name (joomla-projects#11) * Added a container div for fixtures representing the library name * CS - Removed an extra new line * Permissions.js tests Test for permissions * Repeatable.js test suite * Improvements to JCaption tests * README.md update * Modified readme file * Made running tests easier by adding configuration for tests to run on npm test * Core js Improvements * Issue 9 Added jasmine spies and improved code * Issue 9 Fixed an indentation issue * Demo video on Youtube * Inserted the video demonstration link to the readme * Issue 5 Added spies and made code improvements (joomla-projects#31) * Issue 12 Improved code (joomla-projects#34) * Repeatable.js Improvements (joomla-projects#35) * Run Travis JavaScript tests on separated Matrix Build (joomla-projects#39) * Only run Travis tests on PHP 7 * Fix base path issue * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Added own matrix tests for JavaScript * Reverted README.md * Synced README.md to the new version * Synced README.md with new version * Fixed indentations * Synced README.md with 3.6 version * Fixed indentations * Fixed indentations * Added newline at the end of travis-tests.sh * Added missing sudo:false in .travis.yml
yvesh
pushed a commit
that referenced
this pull request
Jun 17, 2017
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30 .
split the pageobject file UserManagerPage.php
add two new pageobject file UserAclPage.php and UserGroupPage.php