This repository was archived by the owner on Mar 17, 2020. It is now read-only.
Adding users.feature scenarios using gherkin #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pritalpatel
force-pushed
the
gherkin-feature-users
branch
5 times, most recently
from
e586cc7 to
e428944
Compare
pritalpatel
force-pushed
the
gherkin-feature-users
branch
from
e428944 to
69413af
Compare
| $I->click(['xpath' => "//div[@id='toolbar-featured']//button"]); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
Functions like the previous one will be moved to step or helper files. But since we will be improving the current code through iterations will merge.
| Scenario: perform a add new user | ||
| Given There is a add user link | ||
| When I create new user with fields Name "register", Login Name "register", Password "register" and Email "[email protected]" | ||
| Then I Save the user |
There was a problem hiding this comment.
This should be "when" not "then"
There was a problem hiding this comment.
Thanks Javi.
I am thinking to refactor it like this,
When I fill following fields Name "register", Login Name "register", Password "register" and Email "[email protected]"
And I Save the user
Then I see the "User successfully saved." messageHow about this?
yvesh
pushed a commit
that referenced
this pull request
Jun 17, 2017
* codestyle * code style * codestyle * codestyle * codestyle * thanks @wojsmol * corrections - thanks @Quy * corrections - thanks @Quy * oops * make @Quy happy * Update article.xml * Remove space * Update config.xml (#14) * Update filter.xml (#15) * Update config.xml (#16) * Update profile.xml (#17) * Update application.xml (#18) * Update article.xml (#19) * Update filter_articles.xml (#20) * Update config.xml (#24) * Update config.xml (#23) * Update filter_fields.xml (#22) * Update filter_featured.xml (#21) * Update override.xml (#25) * Update config.xml * Update config.xml (#26) * Update itemadmin_alias.xml (#30) * Update itemadmin.xml (#29) * Update item.xml (#27) * Update item_alias.xml (#28) * Update itemadmin_url.xml (#31) * Update module.xml (#32) * Update plugin.xml (#33) * Update config.xml (#34) * Update link.xml (#35) * Update config.xml (#36) * Update style.xml (#38) * Update config.xml (#37) * Update note.xml (#42) * Update group.xml (#41) * Update filter_debuggroup.xml (#40) * Update config.xml (#39) * corrections for @andrepereiradasilva * gotya
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #16
Sending users.feature scenario in separate PR from #18