-
Notifications
You must be signed in to change notification settings - Fork 2.3k
test(e2e): update e2e test app to react-native 0.65 #5611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/CMTtqm31JUdWQW8epxMUM25Hhvs5 react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/4vFAcPEVt1egGBRQgc5SrioLt7YJ [Deployment for 64a7729 canceled] |
Codecov Report
@@ Coverage Diff @@
## master #5611 +/- ##
============================================
+ Coverage 53.68% 53.70% +0.02%
- Complexity 631 632 +1
============================================
Files 208 208
Lines 10076 10076
Branches 1543 1543
============================================
+ Hits 5408 5410 +2
+ Misses 4384 4383 -1
+ Partials 284 283 -1 |
d73f582 to
bc31f91
Compare
|
Hello @mikehardy , I have been getting the warning in the console about "new NativeEventEmitter() ..." being called without the listeners methods. I think this is because of the change in the commit 114be1d. The NativeEmitter is being called here RNFBNativeEventEmitter.js. |
Definitely a new issue if you can |
|
@mikehardy I dig some more and create the issue. Thanks. |
bc31f91 to
c188163
Compare
c188163 to
eeb1647
Compare
- includes all the changes from upgrade-helper - remove Podfile post_install minimum iOS version convergence this seems to be an anti-pattern now, Folly+iOS at least fails to compile with this stanza included
eeb1647 to
64a7729
Compare
Description
Update our test app to react-native 0.65
Related issues
Peeled this from #5590 so that one isn't blocked on something less important since it did not work immediately
Verified it with results of #5616 (it was built on that until a moment ago in fact, just re-based it out)
Release Summary
conventional commit (when ready), rebase merge
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
Local and CI runs of all tests should pass
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter