Skip to content

Conversation

@mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Aug 18, 2021

Description

3 easy ones

  • firebase-ios-sdk to 8.6.0
  • basic javascript updates
  • gradle 7.2

Peeled react-native 0.65 out to it's own since it wasn't working immediately #5611

Related issues

Fixes #5571 ?

Release Summary

Conventional commits - rebase merge

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

All tests passing locally and in E2E


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Aug 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/FKV3JEcThqmbLi9zddiT5865jZ57
✅ Preview: https://react-native-firebase-git-mikehardy-dependency-310d7b-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/GFHB1ZEDqqXsk4D337KVCPuPf264
✅ Preview: Canceled

[Deployment for 42468c4 canceled]

@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 383dff9 to 0471a35 Compare August 18, 2021 15:41
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #5610 (0b985a6) into master (8b42e20) will increase coverage by 1.38%.
The diff coverage is n/a.

❗ Current head 0b985a6 differs from pull request most recent head 42468c4. Consider uploading reports for the commit 42468c4 to get more accurate results

@@            Coverage Diff             @@
##           master    #5610      +/-   ##
==========================================
+ Coverage   73.29%   74.67%   +1.38%     
==========================================
  Files         108      108              
  Lines        4444     4444              
  Branches      947      947              
==========================================
+ Hits         3257     3318      +61     
+ Misses       1112     1053      -59     
+ Partials       75       73       -2     

@mikehardy
Copy link
Collaborator Author

RN65 bump appears to be problematic here even though I build-tested / test-executed it in rnfbdemo a ton on rc3 and rc4 so I'm surprised.

Pushed it to CI to see how it works in a clean environment, if RN65 continues to cause trouble I'll peel that commit off in order to get this through and unblock #5571

@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from 0471a35 to d2c4e14 Compare August 18, 2021 16:43
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 18, 2021 16:43 Inactive
@mikehardy mikehardy changed the title build(deps): firebase-ios-sdk 8.6.0 / js updates / react-native 0.65 / gradle 7.2 WIP build(deps): firebase-ios-sdk 8.6.0 / js updates / gradle 7.2 Aug 18, 2021
@mikehardy mikehardy added Workflow: Pending Merge Waiting on CI or similar and removed blocked: customer-response labels Aug 18, 2021
@mikehardy mikehardy force-pushed the @mikehardy/dependency-updates branch from d2c4e14 to 42468c4 Compare August 18, 2021 16:51
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 18, 2021 16:51 Inactive
@mikehardy mikehardy merged commit 84fbb59 into master Aug 18, 2021
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch August 18, 2021 18:23
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants