Skip to content

Conversation

@mikehardy
Copy link
Collaborator

Description

Some updates

Related issues

Release Summary

Conventional commits

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Lots of e2e runs locally, CI will check it as well


Think react-native-firebase is great? Please consider supporting the project with any of the below:

- firestore test needed tests to be async for typing to match
- babel config needed a change for "loose" option to match in all configurations
They hang on auth token fetching for some reason?
@vercel
Copy link

vercel bot commented Aug 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

react-native-firebase – ./

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/GchxdDtTFo2y1qYTxnvop621fNtP
✅ Preview: https://react-native-firebase-git-mikehardy-dependency-310d7b-invertase.vercel.app

react-native-firebase-next – ./website_modular

🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/9pu2S3LDPhsa8ACfuf9YVMcPehP9
✅ Preview: Canceled

[Deployment for 4c2f58c canceled]

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #5590 (f31d898) into master (303811d) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head f31d898 differs from pull request most recent head 4c2f58c. Consider uploading reports for the commit 4c2f58c to get more accurate results

@@             Coverage Diff              @@
##             master    #5590      +/-   ##
============================================
+ Coverage     67.32%   67.34%   +0.03%     
- Complexity      986      988       +2     
============================================
  Files           202      202              
  Lines          9708     9708              
  Branches       1514     1514              
============================================
+ Hits           6535     6537       +2     
  Misses         2754     2754              
+ Partials        419      417       -2     

@mikehardy
Copy link
Collaborator Author

Logged firebase/firebase-tools#3671 with tools repo to track failure on latest rules-unit-testing / emulator

It's not possible to untangle node and react-native types unfortunately,
they clash. It is a known issue and apparently intractable, and
new typescript projects have skipLibCheck on so we acquiesce

Related #4306
@vercel vercel bot temporarily deployed to Preview – react-native-firebase-next August 12, 2021 22:21 Inactive
@mikehardy mikehardy merged commit 90476b8 into master Aug 12, 2021
@mikehardy mikehardy deleted the @mikehardy/dependency-updates branch August 12, 2021 23:20
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants