-
Notifications
You must be signed in to change notification settings - Fork 2.3k
fix(app, android): react-native 0.65 compatibility #5616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). react-native-firebase – ./🔍 Inspect: https://vercel.com/invertase/react-native-firebase/EcTJoDgik3WYtz2r82rfozqnvm1B react-native-firebase-next – ./website_modular🔍 Inspect: https://vercel.com/invertase/react-native-firebase-next/3G4gWo7k1EBB5qrE5tqHTkdmHVB7 [Deployment for acfc895 canceled] |
Codecov Report
@@ Coverage Diff @@
## master #5616 +/- ##
=============================================
- Coverage 73.11% 53.68% -19.42%
- Complexity 0 631 +631
=============================================
Files 109 208 +99
Lines 4476 10076 +5600
Branches 954 1543 +589
=============================================
+ Hits 3272 5408 +2136
- Misses 1126 4384 +3258
- Partials 78 284 +206 |
|
Yes, that's exactly what I meant. I tested it the way you described here and everything works fine. |
|
It's about to be my overnight here so I won't be able to test it for a little while but I'll merge + release tomorrow if everything goes well, while working through #5611 |
f9d66a5 to
ef060fe
Compare
ef060fe to
acfc895
Compare
|
upstream react-native re-wrote the EventEmitter infrastructure, and it's not too hard to work with the new style for RN65+ but it's a bit touchy to handle either RN <= 64 and RN >= 65 at the same time, working through that now then I can release |
## Description Fixes #2297 by adding stub implementations of newly-required methods from react-native 0.65 See e.g. - react-native-device-info/react-native-device-info@3917f33 - invertase/react-native-firebase#5616
Description
As discovered by @wfern we appear to have a missing couple of APIs needed by react-native 0.65
This will hopefully fix that
Test Plan
Hopefully someone can try the patch set (available from this URL - https://github.com/invertase/react-native-firebase/suites/3536859145/artifacts/84635700 - grabbed from the "artifacts" dropdown from the details link on the patches action below 👇 ) - integrate it with https://github.com/ds300/patch-package and should work?
Related issues
Fixes #5614
Release Summary
conventional commits --> rebase merge
Checklist
AndroidiOSe2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter