Skip to content

Generalize argument type of PbList.from from List<T> to Iterable<T> #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2025
Merged

Generalize argument type of PbList.from from List<T> to Iterable<T> #1054

merged 2 commits into from
Sep 25, 2025

Conversation

osa1
Copy link
Member

@osa1 osa1 commented Sep 24, 2025

This is more consistent with List.from and also more efficient as we can avoid redundant List allocations when we have an Iterable instead of a List. This commonly happens when we create a PbList from a chain of map, where etc. calls.

Also update the the factory body to use List.of instead of List.from as we know the Iterable's element type. (List.from takes Iterable<dynamic>, List.of takes Iterable<T>)

cl/810421932

@osa1 osa1 requested a review from sigurdm September 24, 2025 08:57
@osa1 osa1 requested a review from devoncarew September 24, 2025 09:33
@osa1 osa1 merged commit 07eed6e into google:master Sep 25, 2025
11 of 12 checks passed
@osa1 osa1 deleted the pblist_from branch September 25, 2025 10:19
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 25, 2025
@devoncarew
[deps] rev ai, dartdoc, http, protobuf, tools, web, webdev
2c73e8c 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/078abd2..901e2ce):
  901e2ce  2025-09-22  Greg Spencer  Mark "root" as required. (dart-lang/ai#285)

dartdoc (https://github.com/dart-lang/dartdoc/compare/4df6dbe..669b15f):
  669b15f7  2025-09-25  Sam Rawlins  Update deprecated check to consider new annotations (dart-lang/dartdoc#4108)
  42daf01e  2025-09-25  Konstantin Scheglov  When create EmbedderSdk, give it 'languageVersion'. (dart-lang/dartdoc#4110)
  17dc54d1  2025-09-25  Sam Rawlins  Bump updateAnalysisOptions parameter for deprecation (dart-lang/dartdoc#4109)

http (https://github.com/dart-lang/http/compare/d6dd5ec..e0dadd1):
  e0dadd1  2025-09-23  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/http#1819)
  8c5f1b8  2025-09-22  Benjamin Jones  Remove documentation about WebSocketChannel.new in doc comment (dart-lang/http#1823)

protobuf (https://github.com/dart-lang/protobuf/compare/456e2ee..07eed6e):
  07eed6e  2025-09-25  Ömer Sinan Ağacan  Generalize argument type of `PbList.from` from `List<T>` to `Iterable<T>` (google/protobuf.dart#1054)
  0447bd2  2025-09-24  Ömer Sinan Ağacan  Run plugin with asserts when building test protos (google/protobuf.dart#1055)
  660bbc8  2025-09-24  Ömer Sinan Ağacan  Edition support (google/protobuf.dart#1052)
  82fc34f  2025-09-23  Ömer Sinan Ağacan  Improve golden file checking (google/protobuf.dart#1053)

tools (https://github.com/dart-lang/tools/compare/6c1eb21..ecd7dd5):
  ecd7dd52  2025-09-24  Devon Carew  refactor the media types golden table (dart-lang/tools#2168)

web (https://github.com/dart-lang/web/compare/25a0b5b..0baaea4):
  0baaea4  2025-09-23  Nikechukwu  [interop] Add support for destructured parameters (dart-lang/web#469)
  af37d19  2025-09-22  Nikechukwu  [web-generator] Added support for multi-file input for JS Generator (dart-lang/web#470)

webdev (https://github.com/dart-lang/webdev/compare/23aefeb..d2e5593):
  d2e5593b  2025-09-22  Ben Konyi  Format sources using the updated formatter (dart-lang/webdev#2662)

Change-Id: Ia42b257706d22841ba226870b51bb346d9bef67f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451601
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sigurdm sigurdm sigurdm approved these changes

@devoncarew devoncarew Awaiting requested review from devoncarew

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@osa1 @sigurdm