Skip to content

Conversation

devoncarew
Copy link
Member

  • some minor refactoring of the media types golden table to make it a little easier to understand what changes a diff implies

  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:bazel_worker 1.1.3 already published at pub.dev
package:benchmark_harness 2.4.0-wip WIP (no publish necessary)
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.1.3 already published at pub.dev
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.5.0-wip WIP (no publish necessary)
package:clock 1.1.3-wip WIP (no publish necessary)
package:code_builder 4.11.0 already published at pub.dev
package:coverage 1.15.0 already published at pub.dev
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:glob 2.1.3 already published at pub.dev
package:graphs 2.3.3-wip WIP (no publish necessary)
package:html 0.15.6 already published at pub.dev
package:io 1.1.0-wip WIP (no publish necessary)
package:json_rpc_2 4.0.0 already published at pub.dev
package:markdown 7.3.1-wip WIP (no publish necessary)
package:mime 2.0.0 already published at pub.dev
package:oauth2 2.0.4-wip WIP (no publish necessary)
package:package_config 2.3.0-wip WIP (no publish necessary)
package:pool 1.5.2 already published at pub.dev
package:process 5.0.5 already published at pub.dev
package:pub_semver 2.2.0 already published at pub.dev
package:pubspec_parse 1.5.0 already published at pub.dev
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:source_maps 0.10.14-wip WIP (no publish necessary)
package:source_span 1.10.1 already published at pub.dev
package:sse 4.1.8 already published at pub.dev
package:stack_trace 1.12.1 already published at pub.dev
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.1 already published at pub.dev
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.4.0 ready to publish test_reflective_loader-v0.4.0
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 8.0.5 already published at pub.dev
package:watcher 1.1.3 already published at pub.dev
package:yaml 3.1.3 already published at pub.dev
package:yaml_edit 2.2.2 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the generation of the media types markdown table to improve diff readability. The changes in pkgs/mime/tool/media_types.dart use fixed-width padding for table columns. While this is a good idea for cleaner diffs, the implementation has a couple of issues. The hardcoded padding values are insufficient for longer MIME types, causing broken table alignment. Additionally, removing the code formatting (backticks) for MIME types and extensions reduces the readability of the rendered documentation. My review includes a suggestion to dynamically calculate column widths and restore the code formatting to address these issues.

Copy link

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
mime None 2.0.0 2.0.0 2.0.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ⚠️
File Coverage
pkgs/mime/tool/media_types.dart 💔 Not covered

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/bazel_worker/benchmark/benchmark.dart
pkgs/bazel_worker/example/client.dart
pkgs/bazel_worker/example/worker.dart
pkgs/benchmark_harness/integration_test/perf_benchmark_test.dart
pkgs/boolean_selector/example/example.dart
pkgs/clock/lib/clock.dart
pkgs/clock/lib/src/clock.dart
pkgs/clock/lib/src/default.dart
pkgs/clock/lib/src/stopwatch.dart
pkgs/clock/lib/src/utils.dart
pkgs/clock/test/clock_test.dart
pkgs/clock/test/default_test.dart
pkgs/clock/test/stopwatch_test.dart
pkgs/clock/test/utils.dart
pkgs/coverage/lib/src/coverage_options.dart
pkgs/html/example/main.dart
pkgs/html/lib/dom.dart
pkgs/html/lib/dom_parsing.dart
pkgs/html/lib/html_escape.dart
pkgs/html/lib/parser.dart
pkgs/html/lib/src/constants.dart
pkgs/html/lib/src/encoding_parser.dart
pkgs/html/lib/src/html_input_stream.dart
pkgs/html/lib/src/list_proxy.dart
pkgs/html/lib/src/query_selector.dart
pkgs/html/lib/src/token.dart
pkgs/html/lib/src/tokenizer.dart
pkgs/html/lib/src/treebuilder.dart
pkgs/html/lib/src/utils.dart
pkgs/html/test/dom_test.dart
pkgs/html/test/parser_feature_test.dart
pkgs/html/test/parser_test.dart
pkgs/html/test/query_selector_test.dart
pkgs/html/test/selectors/level1_baseline_test.dart
pkgs/html/test/selectors/level1_lib.dart
pkgs/html/test/selectors/selectors.dart
pkgs/html/test/support.dart
pkgs/html/test/tokenizer_test.dart
pkgs/html/test/trie_test.dart
pkgs/html/tool/generate_trie.dart
pkgs/pubspec_parse/test/git_uri_test.dart
pkgs/stack_trace/example/example.dart
pkgs/watcher/test/custom_watcher_factory_test.dart
pkgs/yaml_edit/example/example.dart

This check can be disabled by tagging the PR with skip-license-check.

@devoncarew devoncarew merged commit ecd7dd5 into dart-lang:main Sep 24, 2025
13 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Sep 25, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`.

ai (https://github.com/dart-lang/ai/compare/078abd2..901e2ce):
  901e2ce  2025-09-22  Greg Spencer  Mark "root" as required. (dart-lang/ai#285)

dartdoc (https://github.com/dart-lang/dartdoc/compare/4df6dbe..669b15f):
  669b15f7  2025-09-25  Sam Rawlins  Update deprecated check to consider new annotations (dart-lang/dartdoc#4108)
  42daf01e  2025-09-25  Konstantin Scheglov  When create EmbedderSdk, give it 'languageVersion'. (dart-lang/dartdoc#4110)
  17dc54d1  2025-09-25  Sam Rawlins  Bump updateAnalysisOptions parameter for deprecation (dart-lang/dartdoc#4109)

http (https://github.com/dart-lang/http/compare/d6dd5ec..e0dadd1):
  e0dadd1  2025-09-23  dependabot[bot]  Bump the github-actions group with 3 updates (dart-lang/http#1819)
  8c5f1b8  2025-09-22  Benjamin Jones  Remove documentation about WebSocketChannel.new in doc comment (dart-lang/http#1823)

protobuf (https://github.com/dart-lang/protobuf/compare/456e2ee..07eed6e):
  07eed6e  2025-09-25  Ömer Sinan Ağacan  Generalize argument type of `PbList.from` from `List<T>` to `Iterable<T>` (google/protobuf.dart#1054)
  0447bd2  2025-09-24  Ömer Sinan Ağacan  Run plugin with asserts when building test protos (google/protobuf.dart#1055)
  660bbc8  2025-09-24  Ömer Sinan Ağacan  Edition support (google/protobuf.dart#1052)
  82fc34f  2025-09-23  Ömer Sinan Ağacan  Improve golden file checking (google/protobuf.dart#1053)

tools (https://github.com/dart-lang/tools/compare/6c1eb21..ecd7dd5):
  ecd7dd52  2025-09-24  Devon Carew  refactor the media types golden table (dart-lang/tools#2168)

web (https://github.com/dart-lang/web/compare/25a0b5b..0baaea4):
  0baaea4  2025-09-23  Nikechukwu  [interop] Add support for destructured parameters (dart-lang/web#469)
  af37d19  2025-09-22  Nikechukwu  [web-generator] Added support for multi-file input for JS Generator (dart-lang/web#470)

webdev (https://github.com/dart-lang/webdev/compare/23aefeb..d2e5593):
  d2e5593b  2025-09-22  Ben Konyi  Format sources using the updated formatter (dart-lang/webdev#2662)

Change-Id: Ia42b257706d22841ba226870b51bb346d9bef67f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451601
Commit-Queue: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants