Improve golden file checking #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when I have a typo in the golden file path, `expectGolden` creates a new file, which makes the test pass. Update `expectGolden` to only create (or update if already exists) a golden file when the env variable `PROTOC_UPDATE_GOLDENS` is set. Without the env variable it expects the file to exist, with the right contents. So typos now cause test failures as expected.
Merged
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Sep 25, 2025
Revisions updated by `dart tools/rev_sdk_deps.dart`. ai (https://github.com/dart-lang/ai/compare/078abd2..901e2ce): 901e2ce 2025-09-22 Greg Spencer Mark "root" as required. (dart-lang/ai#285) dartdoc (https://github.com/dart-lang/dartdoc/compare/4df6dbe..669b15f): 669b15f7 2025-09-25 Sam Rawlins Update deprecated check to consider new annotations (dart-lang/dartdoc#4108) 42daf01e 2025-09-25 Konstantin Scheglov When create EmbedderSdk, give it 'languageVersion'. (dart-lang/dartdoc#4110) 17dc54d1 2025-09-25 Sam Rawlins Bump updateAnalysisOptions parameter for deprecation (dart-lang/dartdoc#4109) http (https://github.com/dart-lang/http/compare/d6dd5ec..e0dadd1): e0dadd1 2025-09-23 dependabot[bot] Bump the github-actions group with 3 updates (dart-lang/http#1819) 8c5f1b8 2025-09-22 Benjamin Jones Remove documentation about WebSocketChannel.new in doc comment (dart-lang/http#1823) protobuf (https://github.com/dart-lang/protobuf/compare/456e2ee..07eed6e): 07eed6e 2025-09-25 Ömer Sinan Ağacan Generalize argument type of `PbList.from` from `List<T>` to `Iterable<T>` (google/protobuf.dart#1054) 0447bd2 2025-09-24 Ömer Sinan Ağacan Run plugin with asserts when building test protos (google/protobuf.dart#1055) 660bbc8 2025-09-24 Ömer Sinan Ağacan Edition support (google/protobuf.dart#1052) 82fc34f 2025-09-23 Ömer Sinan Ağacan Improve golden file checking (google/protobuf.dart#1053) tools (https://github.com/dart-lang/tools/compare/6c1eb21..ecd7dd5): ecd7dd52 2025-09-24 Devon Carew refactor the media types golden table (dart-lang/tools#2168) web (https://github.com/dart-lang/web/compare/25a0b5b..0baaea4): 0baaea4 2025-09-23 Nikechukwu [interop] Add support for destructured parameters (dart-lang/web#469) af37d19 2025-09-22 Nikechukwu [web-generator] Added support for multi-file input for JS Generator (dart-lang/web#470) webdev (https://github.com/dart-lang/webdev/compare/23aefeb..d2e5593): d2e5593b 2025-09-22 Ben Konyi Format sources using the updated formatter (dart-lang/webdev#2662) Change-Id: Ia42b257706d22841ba226870b51bb346d9bef67f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451601 Commit-Queue: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when I have a typo in the golden file path,
expectGoldencreates a new file, which makes the test pass.Locally I can notice the new file if I run
git status, but if I'm not careful and rely on CI, because the tests pass, I can merge the PR.Update
expectGoldento only create (or update if already exists) a golden file when the env variablePROTOC_UPDATE_GOLDENSis set.Without the env variable it expects the file to exist, with the right contents. So typos now cause test failures as expected.