Skip to content

Generalize argument type of PbList.from from List<T> to Iterable<T> #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2025
Merged

Generalize argument type of PbList.from from List<T> to Iterable<T> #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a545d8b
Generalize argument type of `PbList.from` from `List<T>` to `Iterable…
osa1 Sep 24, 2025
591a03b
Update changelog
osa1 Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions protobuf/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,13 @@
* Fix unknown enum handling in `GeneratedMessage.mergeFromProto3Json` when
the `ignoreUnknownFields` optional argument is `true`. ([#853])
* Add `BuilderInfo` methods to support protoc-plugin 23.0.0. ([#1047])
* Generalize argument type of `PbList.from` from `List<T>` to `Iterable<T>`.
([#1054])

[#742]: https://github.com/google/protobuf.dart/pull/742
[#853]: https://github.com/google/protobuf.dart/pull/853
[#1047]: https://github.com/google/protobuf.dart/pull/1047
[#1054]: https://github.com/google/protobuf.dart/pull/1054

## 4.2.0

Expand Down
4 changes: 2 additions & 2 deletions protobuf/lib/src/protobuf/pb_list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ class PbList<E> extends ListBase<E> {
_check = _checkNotNull,
_isReadOnly = true;

PbList.from(List<E> from)
: _wrappedList = List<E>.from(from),
PbList.from(Iterable<E> from)
: _wrappedList = List<E>.of(from),
_check = _checkNotNull;

@override
Expand Down
Loading