This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[Impeller] Added a switch to turn on vulkan" #42660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5007e9.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
added
the
autosubmit
|
This was discussed in another channel, but sounds like the runtime flag was adding too much size to the engine. |
|
The magnitude of the size was not a huge problem if it's truly necessary. We have time to investigate offline to make sure about that after a revert. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2023
|
Yea, I guess I'm a bit concerned because if our plan is to have a runtime check for Vulkan vs OpenGLES based on the capabilities of the device this is going to be a cost we will have to incur. If that's not something we are willing to accept we'll have to come up with a different strategy for Android. The PR only would have affected the stripping of code related to |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 9, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 9, 2023
…sions) (#128554) Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) Manual roll requested by [email protected] flutter/engine@a5f7d5d...8f9e608 2023-06-09 [email protected] Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688) 2023-06-09 [email protected] [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667) 2023-06-09 [email protected] [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687) 2023-06-09 [email protected] Document the use of realm in archives. (flutter/engine#42682) 2023-06-09 [email protected] Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684) 2023-06-08 [email protected] Prevent double upload of benchmarks. (flutter/engine#42683) 2023-06-08 [email protected] Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680) 2023-06-08 [email protected] Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679) 2023-06-08 [email protected] Replace benchmarks with its v2 version. (flutter/engine#42677) 2023-06-08 [email protected] [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678) 2023-06-08 [email protected] [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676) 2023-06-08 [email protected] Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673) 2023-06-08 [email protected] [Linux] composing delta fixes (flutter/engine#42648) 2023-06-08 [email protected] Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409) 2023-06-08 [email protected] Fix license hash (flutter/engine#42675) 2023-06-08 [email protected] Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671) 2023-06-08 [email protected] Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670) 2023-06-08 [email protected] Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668) 2023-06-08 [email protected] [Impeller] sort all vertex inputs by location. (flutter/engine#42664) 2023-06-08 [email protected] Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662) 2023-06-08 [email protected] Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660) 2023-06-08 [email protected] Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659) 2023-06-08 [email protected] Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658) 2023-06-08 [email protected] Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655) 2023-06-08 [email protected] Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657) 2023-06-08 [email protected] Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651) 2023-06-08 [email protected] Benchmarks configurations for engine v2. (flutter/engine#42622) 2023-06-08 [email protected] Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645) 2023-06-08 [email protected] Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646) 2023-06-07 [email protected] Roll dart to 3.1.0-180.0.dev (flutter/engine#42638) 2023-06-07 [email protected] Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #42585
Reverting to investigate flutter/flutter#128484