Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] sort all vertex inputs by location. #42664

Merged
merged 2 commits into from
Jun 8, 2023
Merged

[Impeller] sort all vertex inputs by location. #42664

merged 2 commits into from
Jun 8, 2023

Conversation

jonahwilliams
Copy link
Contributor

Fixes flutter/flutter#128283

Why doesn't this happen elsewhere? might depend on how spirv compiles shaders or the order they run in. Long term fix is #42628 which computes all offset data in the compiler

flutter_04

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams requested a review from dnfield June 8, 2023 16:20
dnfield
dnfield reviewed Jun 8, 2023
View reviewed changes
impeller/renderer/vertex_descriptor.cc
inputs_.emplace_back(*stage_inputs[i]);
}
// TODO(jonahwilliams): vulkan shader stage needed sorting too. Remove once
// autogenerated headers include offset information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link an issue tracking this work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jonahwilliams
Copy link
Contributor Author

I think this actually fixed the shadows too

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit auto-submit bot merged commit 2bdf756 into flutter:main Jun 8, 2023
@jonahwilliams jonahwilliams deleted the fix_text_vulkan branch June 8, 2023 17:47
@gaaclarke
Copy link
Member

Can we at a minimum add an assert that these are sorted so it doesn't revert? This is the sort of thing you'd wish validation layers would catch.

@jonahwilliams
Copy link
Contributor Author

Will be actually fixed via #42628 . I'm not worried about it regressing

@gaaclarke
Copy link
Member

Just for my understanding, is this is the manifestation of the problem in the frame debugger?

Screenshot 2023-06-08 at 11 05 39 AM

@jonahwilliams
Copy link
Contributor Author

Yup - notice the offsets on the right are computed as if they're sorted.

@jonahwilliams
Copy link
Contributor Author

the gles and metal backends do their own sorting, while vulkan was missing one.

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
7c2dcbd 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
c868224 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
9d70cfb 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
e36ba15 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
6ea5261 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
d3bf4b2 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
c5d577d 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
c0781fa 
…ine#42664)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
2bdf75666 [Impeller] sort all vertex inputs by location. (flutter/eng…
38be388 
…ine#42664)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revi…
80b9ac2 
…sions) (#128554)

Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions)

Manual roll requested by [email protected]

flutter/engine@a5f7d5d...8f9e608

2023-06-09 [email protected] Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688)
2023-06-09 [email protected] [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667)
2023-06-09 [email protected] [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687)
2023-06-09 [email protected] Document the use of realm in archives. (flutter/engine#42682)
2023-06-09 [email protected] Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684)
2023-06-08 [email protected] Prevent double upload of benchmarks. (flutter/engine#42683)
2023-06-08 [email protected] Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680)
2023-06-08 [email protected] Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679)
2023-06-08 [email protected] Replace benchmarks with its v2 version. (flutter/engine#42677)
2023-06-08 [email protected] [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678)
2023-06-08 [email protected] [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676)
2023-06-08 [email protected] Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673)
2023-06-08 [email protected] [Linux] composing delta fixes (flutter/engine#42648)
2023-06-08 [email protected] Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409)
2023-06-08 [email protected] Fix license hash (flutter/engine#42675)
2023-06-08 [email protected] Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671)
2023-06-08 [email protected] Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670)
2023-06-08 [email protected] Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668)
2023-06-08 [email protected] [Impeller] sort all vertex inputs by location. (flutter/engine#42664)
2023-06-08 [email protected] Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662)
2023-06-08 [email protected] Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660)
2023-06-08 [email protected] Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659)
2023-06-08 [email protected] Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658)
2023-06-08 [email protected] Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655)
2023-06-08 [email protected] Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657)
2023-06-08 [email protected] Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651)
2023-06-08 [email protected] Benchmarks configurations for engine v2. (flutter/engine#42622)
2023-06-08 [email protected] Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645)
2023-06-08 [email protected] Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646)
2023-06-07 [email protected] Roll dart to 3.1.0-180.0.dev (flutter/engine#42638)
2023-06-07 [email protected] Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv
  fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller needs tests
Projects
No open projects
Impeller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] vulkan: flutter gallery text isn't rendering
3 participants
@jonahwilliams @gaaclarke @dnfield