Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Prevent double upload of benchmarks. #42683

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Prevent double upload of benchmarks. #42683

merged 1 commit into from
Jun 8, 2023

Conversation

godofredoc
Copy link
Contributor

The benchmarks have been migrated to v2 but the legacy build is uploading benchmarks even when running on staging.

Bug: flutter/flutter#127678

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Prevent double upload of benchmarks.
d4a84b9 
The benchmarks have been migrated to v2 but the legacy build is
uploading benchmarks even when running on staging.

Bug: flutter/flutter#127678
@godofredoc godofredoc requested a review from zanderso June 8, 2023 22:46
@godofredoc
Copy link
Contributor Author

Missed to set the upload property to false in the previous PR

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit auto-submit bot merged commit cabd69a into flutter:main Jun 8, 2023
@godofredoc godofredoc deleted the fix_benchmarks branch June 8, 2023 23:51
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
cabd69a3b Prevent double upload of benchmarks. (flutter/engine#42683)
2db3c4b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
cabd69a3b Prevent double upload of benchmarks. (flutter/engine#42683)
873ec08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
cabd69a3b Prevent double upload of benchmarks. (flutter/engine#42683)
8c8439c
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 9, 2023
@engine-flutter-autoroll
Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revi…
80b9ac2 
…sions) (#128554)

Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions)

Manual roll requested by [email protected]

flutter/engine@a5f7d5d...8f9e608

2023-06-09 [email protected] Revert Dart to 3.1.0-180.0.dev (flutter/engine#42688)
2023-06-09 [email protected] [fuchsia] Bump the target API level to 12, and pass it to fidlc (flutter/engine#42667)
2023-06-09 [email protected] [Impeller] Add tests for foreground blends with mask blurs (flutter/engine#42687)
2023-06-09 [email protected] Document the use of realm in archives. (flutter/engine#42682)
2023-06-09 [email protected] Roll ANGLE from 76b0e7f38b44 to d8339e78db54 (1 revision) (flutter/engine#42684)
2023-06-08 [email protected] Prevent double upload of benchmarks. (flutter/engine#42683)
2023-06-08 [email protected] Roll ANGLE from 5215293366f0 to 76b0e7f38b44 (2 revisions) (flutter/engine#42680)
2023-06-08 [email protected] Remove all the uses of master branch in the .ci.yaml file. (flutter/engine#42679)
2023-06-08 [email protected] Replace benchmarks with its v2 version. (flutter/engine#42677)
2023-06-08 [email protected] [Impeller] Reorder blend filter checks to avoid unnecessary destination snapshot (flutter/engine#42678)
2023-06-08 [email protected] [Impeller] Specify blend mode on blend filter commands (flutter/engine#42676)
2023-06-08 [email protected] Roll ANGLE from c49674d1565c to 5215293366f0 (1 revision) (flutter/engine#42673)
2023-06-08 [email protected] [Linux] composing delta fixes (flutter/engine#42648)
2023-06-08 [email protected] Fix: invalid time-point comparison between each from different clock source (flutter/engine#42409)
2023-06-08 [email protected] Fix license hash (flutter/engine#42675)
2023-06-08 [email protected] Revert Dart to 3.1.0-184.0.dev (flutter/engine#42671)
2023-06-08 [email protected] Roll ANGLE from b5d261ac5c5b to c49674d1565c (2 revisions) (flutter/engine#42670)
2023-06-08 [email protected] Roll Dart SDK from b7fe6e0c274c to 3a9145a57432 (1 revision) (flutter/engine#42668)
2023-06-08 [email protected] [Impeller] sort all vertex inputs by location. (flutter/engine#42664)
2023-06-08 [email protected] Roll ANGLE from 05e087658b10 to b5d261ac5c5b (1 revision) (flutter/engine#42662)
2023-06-08 [email protected] Revert "[Impeller] Added a switch to turn on vulkan" (flutter/engine#42660)
2023-06-08 [email protected] Roll ANGLE from 15a29438b099 to 05e087658b10 (6 revisions) (flutter/engine#42659)
2023-06-08 [email protected] Roll Fuchsia Linux SDK from aMTaMP0DdKdJnxSbc... to lPCv1NshK-tvjtLgC... (flutter/engine#42658)
2023-06-08 [email protected] Roll Fuchsia Mac SDK from DL1QQ5eZRVNARqLx-... to ukXXOXtI7uRIukzF5... (flutter/engine#42655)
2023-06-08 [email protected] Roll Dart SDK from f0ae96d202ca to b7fe6e0c274c (1 revision) (flutter/engine#42657)
2023-06-08 [email protected] Roll Dart SDK from 9e633e463902 to f0ae96d202ca (1 revision) (flutter/engine#42651)
2023-06-08 [email protected] Benchmarks configurations for engine v2. (flutter/engine#42622)
2023-06-08 [email protected] Roll Skia from 1a3adf848e61 to 8fdbbca7d35d (1 revision) (flutter/engine#42645)
2023-06-08 [email protected] Roll Dart SDK from bbce07ad3944 to 9e633e463902 (3 revisions) (flutter/engine#42646)
2023-06-07 [email protected] Roll dart to 3.1.0-180.0.dev (flutter/engine#42638)
2023-06-07 [email protected] Roll Skia from 156542f8bf13 to 1a3adf848e61 (1 revision) (flutter/engine#42644)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from aMTaMP0DdKdJ to lPCv1NshK-tv
  fuchsia/sdk/core/mac-amd64 from DL1QQ5eZRVNA to ukXXOXtI7uRI

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zanderso zanderso Awaiting requested review from zanderso

@ricardoamador ricardoamador Awaiting requested review from ricardoamador

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @zanderso