[Impeller] Added a switch to turn on vulkan #42585

gaaclarke · 2023-06-06T00:16:08Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2023-06-06T00:16:11Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

gaaclarke · 2023-06-07T16:55:39Z

Dan is not available today so I added @jason-simmons

jason-simmons · 2023-06-07T17:24:30Z

shell/platform/android/platform_view_android.cc

    case AndroidRenderingAPI::kSoftware:
      return std::make_unique<AndroidSurfaceSoftware>();
    case AndroidRenderingAPI::kOpenGLES:
+      FML_DLOG(ERROR) << "using opengl";


Remove this and change the "Using the Impeller rendering backend" log in android_surface_gl_impeller.cc to mention OpenGL ES

jason-simmons · 2023-06-07T17:25:27Z

shell/platform/android/platform_view_android.cc

-      // backend.
-#if false
-    return std::make_unique<AndroidSurfaceVulkanImpeller>(
+      FML_DLOG(ERROR) << "using vulkan";


Remove this and add a "Using the Impeller Vulkan rendering backend" log to android_surface_vulkan_impeller.cc similar to the one for OpenGL ES

jason-simmons · 2023-06-07T17:31:49Z

shell/common/switches.h

           "Impeller is not supported on the platform.")
+DEF_SWITCH(ImpellerBackend,
+           "impeller-backend",
+           "Hardcodes a selection of which impeller backend to use. (ex "


Change the description (and the comment in settings.h) to reflect that this is modifiable and not hardcoded
(e.g. "Requests a particular Impeller backend on platforms that support multiple backends")

gaaclarke · 2023-06-07T17:50:18Z

I also switched the "opengl" value to "opengles" to be more correct.

gaaclarke · 2023-06-07T17:52:12Z

I've pushed 2 more commits to this branch and it doesn't seem to be showing up in the pr: https://github.com/gaaclarke/engine/commits/vulkan-switch

gaaclarke · 2023-06-07T17:58:37Z

This seems to be a known github issue as reported by https://www.githubstatus.com/

…#42585)

…128460) flutter/engine@4f4486b...1089ce6 2023-06-07 [email protected] [Impeller] Add buffer to texture blit for Vulkan. (flutter/engine#41706) 2023-06-07 [email protected] [macOS] Add platformview creation parameter support (flutter/engine#42607) 2023-06-07 [email protected] [Impeller] Added a switch to turn on vulkan (flutter/engine#42585) 2023-06-07 [email protected] Roll ANGLE from f8220fa3a729 to 15a29438b099 (1 revision) (flutter/engine#42627) 2023-06-07 [email protected] Bump Chrome version to 114 for testing (flutter/engine#42623) 2023-06-07 [email protected] Roll Skia from d607cbb0db78 to 773765ca1dd2 (7 revisions) (flutter/engine#42624) 2023-06-07 [email protected] [Linux][a11y] implement AtkText::get_text/string_at_offset() (flutter/engine#38144) 2023-06-07 [email protected] Roll ANGLE from 176989ad00cc to f8220fa3a729 (1 revision) (flutter/engine#42621) 2023-06-07 [email protected] Roll Skia from ee90e9ae2e62 to d607cbb0db78 (1 revision) (flutter/engine#42618) 2023-06-07 [email protected] Roll ANGLE from 1ad4ae4d63bf to 176989ad00cc (1 revision) (flutter/engine#42617) 2023-06-07 [email protected] Revert "[Android] Return keyboard pressed state" (flutter/engine#42616) 2023-06-07 [email protected] Roll Skia from bde894438f29 to ee90e9ae2e62 (1 revision) (flutter/engine#42614) 2023-06-07 [email protected] Roll Fuchsia Linux SDK from lpbkSRJBMkPs0FM7_... to sEHtHM1iFt79roP-x... (flutter/engine#42613) 2023-06-07 [email protected] Roll Skia from cd3e1665dcd1 to bde894438f29 (1 revision) (flutter/engine#42612) 2023-06-07 [email protected] Roll ANGLE from 16841d6256da to 1ad4ae4d63bf (1 revision) (flutter/engine#42611) 2023-06-07 [email protected] [Impeller] Reland 2: Add Impeller Metal support in the embedder API (#42411) (flutter/engine#42597) 2023-06-07 [email protected] Roll Skia from a01f49f539ab to cd3e1665dcd1 (1 revision) (flutter/engine#42610) 2023-06-07 [email protected] Roll Fuchsia Mac SDK from atrYtfHWi2cmV9B_C... to ojwVlxZWrbsG4WGSE... (flutter/engine#42609) 2023-06-07 [email protected] Roll Skia from 521b8c4bb011 to a01f49f539ab (4 revisions) (flutter/engine#42608) 2023-06-07 [email protected] Roll Skia from cef18d10b363 to 521b8c4bb011 (1 revision) (flutter/engine#42605) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from lpbkSRJBMkPs to sEHtHM1iFt79 fuchsia/sdk/core/mac-amd64 from atrYtfHWi2cm to ojwVlxZWrbsG If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This reverts commit f5007e9.

Reverts #42585 Reverting to investigate flutter/flutter#128484

fixes flutter/flutter#128286 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

relands #42585 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

flutter-dashboard bot added platform-android needs tests labels Jun 6, 2023

gaaclarke changed the title ~~Added a switch to turn on vulkan~~ [Impeller] Added a switch to turn on vulkan Jun 6, 2023

gaaclarke requested review from dnfield and jason-simmons June 6, 2023 00:16

jason-simmons reviewed Jun 7, 2023

View reviewed changes

jason-simmons approved these changes Jun 7, 2023

View reviewed changes

gaaclarke added 4 commits June 7, 2023 11:13

Added a switch to turn on vulkan

38da5e9

lint fix

3ce3f71

jason feedback

ff12906

renamed "opengl" to "opengles" (poke)

445df7b

gaaclarke force-pushed the vulkan-switch branch 2 times, most recently from 605b1b3 to 5ac7c21 Compare June 7, 2023 18:20

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023

auto-submit bot merged commit f5007e9 into flutter:main Jun 7, 2023

engine-flutter-autoroll mentioned this pull request Jun 7, 2023

Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) flutter/flutter#128460

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 7, 2023

f5007e9f0 [Impeller] Added a switch to turn on vulkan (flutter/engine…

28f925c

…#42585)

zanderso mentioned this pull request Jun 8, 2023

[Impeller] Vulkan backend binary size increase investigation flutter/flutter#128484

Closed

zanderso added a commit that referenced this pull request Jun 8, 2023

Revert "[Impeller] Added a switch to turn on vulkan (#42585)"

9912c8e

This reverts commit f5007e9.

zanderso mentioned this pull request Jun 8, 2023

Revert "[Impeller] Added a switch to turn on vulkan" #42660

Merged

zanderso added a commit that referenced this pull request Jun 8, 2023

Revert "[Impeller] Added a switch to turn on vulkan" (#42660)

30a2d61

Reverts #42585 Reverting to investigate flutter/flutter#128484

gaaclarke mentioned this pull request Jun 8, 2023

[Impeller] Reland: Added a switch to turn on vulkan #42669

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] Added a switch to turn on vulkan #42585

[Impeller] Added a switch to turn on vulkan #42585

Uh oh!

gaaclarke commented Jun 6, 2023

Uh oh!

flutter-dashboard bot commented Jun 6, 2023

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

jason-simmons Jun 7, 2023

Uh oh!

gaaclarke Jun 7, 2023

Uh oh!

jason-simmons Jun 7, 2023

Uh oh!

gaaclarke Jun 7, 2023

Uh oh!

jason-simmons Jun 7, 2023

Uh oh!

gaaclarke Jun 7, 2023

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

Uh oh!

[Impeller] Added a switch to turn on vulkan #42585

[Impeller] Added a switch to turn on vulkan #42585

Uh oh!

Conversation

gaaclarke commented Jun 6, 2023

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jun 6, 2023

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

jason-simmons Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

jason-simmons Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

jason-simmons Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

gaaclarke Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

gaaclarke commented Jun 7, 2023

Uh oh!

Uh oh!