This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Teardown external view embedder prior to unmerging threads #31122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2022 11:24
…reads (flutter#30893)" (flutter#31108)" This reverts commit 55420ec.
Author
blasten
changed the title
Author
|
Friendly ping |
GaryQian
approved these changes
Feb 3, 2022
blasten
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 3, 2022
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Feb 8, 2022
itsjustkevin
added a commit
that referenced
this pull request
Feb 9, 2022
* 'Update Dart SDK to 0180af2' * [Web Text Input] ensure the input element is put in the DOM on desktop safari (#30885) * Reland: Teardown external view embedder prior to unmerging threads (#31122) * Don't remove views while the rasterizer is torn down (#31229) * [web] roll CanvasKit 0.32.0; fix frame order in animated images (#30680) * roll CanvasKit 0.32.0 * Fix frame order in WASM image codecs * [web] roll CanvasKit to 0.33.0 (#31240) * 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml' * remove candidate from enabled_branches * resolved merge conflict in DEPS file for the canvaskit_cipd_instance key * update license hash * resolving presubmit failures on android tests Co-authored-by: Kevin Chisholm <[email protected]> Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: eggfly <[email protected]>
Contributor
|
Now that flutter/flutter#96679 has been fixed, should we revert this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #30893
The timeout seen in flutter/flutter#97351 was caused by a deadlock in Shell::OnPlatformViewDestroyed`.
a57f079 fixes the deadlock.
Fixes flutter/flutter#96661