Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Feb 3, 2022

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Feb 3, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@harryterkelsen harryterkelsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yjbanov yjbanov merged commit 98340f9 into flutter:main Feb 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2022
itsjustkevin pushed a commit to itsjustkevin/engine that referenced this pull request Feb 8, 2022
itsjustkevin added a commit that referenced this pull request Feb 9, 2022
* 'Update Dart SDK to 0180af2'

* [Web Text Input] ensure the input element is put in the DOM on desktop safari (#30885)

* Reland: Teardown external view embedder prior to unmerging threads (#31122)

* Don't remove views while the rasterizer is torn down (#31229)

* [web] roll CanvasKit 0.32.0; fix frame order in animated images (#30680)

* roll CanvasKit 0.32.0
* Fix frame order in WASM image codecs

* [web] roll CanvasKit to 0.33.0 (#31240)

* 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml'

* remove candidate from enabled_branches

* resolved merge conflict in DEPS file for the canvaskit_cipd_instance key

* update license hash

* resolving presubmit failures on android tests

Co-authored-by: Kevin Chisholm <[email protected]>
Co-authored-by: LongCatIsLooong <[email protected]>
Co-authored-by: Emmanuel Garcia <[email protected]>
Co-authored-by: Yegor <[email protected]>
Co-authored-by: eggfly <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs tests platform-web Code specifically for the web engine

Projects

None yet

2 participants