This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Web Text Input] ensure the input element is put in the DOM on desktop safari #30885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
mdebbar
approved these changes
Jan 18, 2022
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
Thanks for fixing this issue!
LongCatIsLooong
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2022
* bdab647 Roll Skia from 9f231c330962 to 8276fa8ef102 (2 revisions) (flutter/engine#30912) * 7002447 Remove redundant `--template` arguments from code samples (flutter/engine#30909) * cef8bce [Web Text Input] ensure the input element is put in the DOM on desktop safari (flutter/engine#30885) * 31b1a1d cleanup #28013 (flutter/engine#29500)
itsjustkevin
pushed a commit
to itsjustkevin/engine
that referenced
this pull request
Feb 8, 2022
itsjustkevin
added a commit
that referenced
this pull request
Feb 9, 2022
* 'Update Dart SDK to 0180af2' * [Web Text Input] ensure the input element is put in the DOM on desktop safari (#30885) * Reland: Teardown external view embedder prior to unmerging threads (#31122) * Don't remove views while the rasterizer is torn down (#31229) * [web] roll CanvasKit 0.32.0; fix frame order in animated images (#30680) * roll CanvasKit 0.32.0 * Fix frame order in WASM image codecs * [web] roll CanvasKit to 0.33.0 (#31240) * 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml' * remove candidate from enabled_branches * resolved merge conflict in DEPS file for the canvaskit_cipd_instance key * update license hash * resolving presubmit failures on android tests Co-authored-by: Kevin Chisholm <[email protected]> Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Emmanuel Garcia <[email protected]> Co-authored-by: Yegor <[email protected]> Co-authored-by: eggfly <[email protected]>
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* bdab647 Roll Skia from 9f231c330962 to 8276fa8ef102 (2 revisions) (flutter/engine#30912) * 7002447 Remove redundant `--template` arguments from code samples (flutter/engine#30909) * cef8bce [Web Text Input] ensure the input element is put in the DOM on desktop safari (flutter/engine#30885) * 31b1a1d cleanup flutter#28013 (flutter/engine#29500)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#96411
Now that the framework only calls
showonce, it should try putting the input element into the DOM.If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.