This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove redundant --template arguments from code samples
#30909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gspencergoog
force-pushed
the
extract_text_samples
branch
from
37c3755 to
667dcfa
Compare
HansMuller
approved these changes
Jan 18, 2022
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM
Thanks for fixing the typos!
Contributor
|
test-exempt: only affects comments |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2022
* bdab647 Roll Skia from 9f231c330962 to 8276fa8ef102 (2 revisions) (flutter/engine#30912) * 7002447 Remove redundant `--template` arguments from code samples (flutter/engine#30909) * cef8bce [Web Text Input] ensure the input element is put in the DOM on desktop safari (flutter/engine#30885) * 31b1a1d cleanup #28013 (flutter/engine#29500)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* bdab647 Roll Skia from 9f231c330962 to 8276fa8ef102 (2 revisions) (flutter/engine#30912) * 7002447 Remove redundant `--template` arguments from code samples (flutter/engine#30909) * cef8bce [Web Text Input] ensure the input element is put in the DOM on desktop safari (flutter/engine#30885) * 31b1a1d cleanup flutter#28013 (flutter/engine#29500)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes redundant
--templatearguments from the samples that I should have removed before in #30827 .Also, fixed a bunch of spelling misteaks.
Tests