Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Teardown external view embedder prior to unmerging threads (#30893)" #31108

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Revert "Teardown external view embedder prior to unmerging threads (#30893)" #31108

merged 1 commit into from
Jan 27, 2022

Conversation

@ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Jan 27, 2022 •
edited
Loading

Fixes flutter/flutter#97351

Reverts #30893

/cc @blasten @zanderso @GaryQian @chinmaygarde @cyanglaz @stuartmorgan

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@zanderso
Copy link
Member

zanderso commented Jan 27, 2022

Tree is green. Status is propagating here. Landing manually.

@zanderso zanderso merged commit 55420ec into flutter:main Jan 27, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 27, 2022
@engine-flutter-autoroll
55420ec Revert "Teardown external view embedder prior to unmerging th…
9c573d2 
…reads (flutter#30893)" (flutter/engine#31108)
blasten pushed a commit to blasten/engine that referenced this pull request Jan 28, 2022
Revert "Revert "Teardown external view embedder prior to unmerging th…
5f0d843 
…reads (flutter#30893)" (flutter#31108)"

This reverts commit 55420ec.
@jason-simmons jason-simmons mentioned this pull request Jan 28, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GaryQian GaryQian Awaiting requested review from GaryQian

2 more reviewers

@blasten blasten blasten approved these changes

@zanderso zanderso zanderso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter_gallery__back_button_memory timing out after Engine roll

3 participants

@ColdPaleLight @zanderso @blasten