Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Automatically download Noto fonts as backup fonts in CanvasKit mode #23728

Merged
merged 18 commits into from
Jan 21, 2021
Merged

Automatically download Noto fonts as backup fonts in CanvasKit mode #23728

merged 18 commits into from
Jan 21, 2021

Conversation

@harryterkelsen
Copy link
Contributor

Re-land of #23096

Fixes flutter/flutter#53897
Fixes flutter/flutter#58496
Fixes flutter/flutter#58506
Fixes flutter/flutter#73628

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Jan 15, 2021
yjbanov
yjbanov reviewed Jan 16, 2021
View reviewed changes
@harryterkelsen harryterkelsen mentioned this pull request Jan 20, 2021
Merged
yjbanov
yjbanov reviewed Jan 20, 2021
View reviewed changes
yjbanov
yjbanov approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 5b9cd44 into flutter:master Jan 21, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
330f19a 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
bd1a237 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
d001e02 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
d4c774a 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
4791a5f 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
dff6abc 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
42774f3 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
25889a8 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
1c52e2b 
…t mode (flutter/engine#23728)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKi…
8470ffa 
…t mode (flutter/engine#23728)
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2021
@engine-flutter-autoroll
Roll Engine from 90641fa to fdddf87 (32 revisions) (#74517)
ea3aa67 
* 5b2defd Roll Fuchsia Mac SDK from MrtHftV0U... to 7nZajqutF... (flutter/engine#23827)

* c8ffb20 Roll Skia from 87a055b02027 to e0d023562bd9 (1 revision) (flutter/engine#23829)

* 296902b implemented GetMainContext() for opengl (flutter/engine#23634)

* 5cf3eae Roll Skia from e0d023562bd9 to 982127b7d57d (4 revisions) (flutter/engine#23831)

* fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

* b241537 Roll Fuchsia Linux Toolchain from git_revision:2c0536b76b35fa592ac7b4a0e4bb176eaf55af75 to IJxh_9dNS... (flutter/engine#23832)

* 5c2003f Roll Skia from 982127b7d57d to 6de1e52d0b12 (1 revision) (flutter/engine#23834)

* 5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKit mode (flutter/engine#23728)

* 70a6824 Roll Dart SDK from 5e24a66b1bb8 to 704928da5702 (2 revisions) (flutter/engine#23838)

* b0c46d8 Roll Skia from 6de1e52d0b12 to 8a37fb2c605b (5 revisions) (flutter/engine#23836)

* d4132ea Use references when iterating over SkParagraph text boxes (flutter/engine#23837)

* 87960d8 Fix typo in embedder unit tests (flutter/engine#23783)

* 7f66714 iOS deeplink sends "path + query" instead of just path (flutter/engine#23562)

* 1474d08 Roll Skia from 8a37fb2c605b to 37d16f135265 (4 revisions) (flutter/engine#23839)

* 3da13fc Make android more lenient when it comes to out-of-order key event responses (flutter/engine#23604)

* 9223073 Fix background crash when FlutterView going appear while app goes background (flutter/engine#23175)

* 7c19824 Pass the filename directly to JNI for loading deferred component. (flutter/engine#23824)

* 5dc2469 Reland path vol tracker (flutter/engine#23840)

* e7e76f1 Roll Skia from 37d16f135265 to e89d8ea20b62 (2 revisions) (flutter/engine#23841)

* 07f4861 Roll Dart SDK from 704928da5702 to 1db2d4d95562 (1 revision) (flutter/engine#23846)

* 993ab78 Roll Skia from e89d8ea20b62 to c09761f57605 (1 revision) (flutter/engine#23843)

* a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)

* 475a234 Roll Fuchsia Linux SDK from UGavhI1zv... to mODEe2CNk... (flutter/engine#23848)

* b51da31 Roll Skia from c09761f57605 to 450f8565c7f3 (5 revisions) (flutter/engine#23851)

* cb7106d Roll Skia from 450f8565c7f3 to 372791761157 (1 revision) (flutter/engine#23855)

* 69980e5 Roll Fuchsia Mac SDK from 7nZajqutF... to tuJCioUf3... (flutter/engine#23857)

* 20ff574 Roll Skia from 372791761157 to ce75036b3eaf (4 revisions) (flutter/engine#23858)

* 0118b54 Implements accessibility bridge in common library (flutter/engine#23491)

* ffc77f0 Search multiple paths when loading deferred component .so files. (flutter/engine#23849)

* 71d264d Revert "implemented GetMainContext() for opengl (#23634)" (flutter/engine#23859)

* fb48735 Roll Skia from ce75036b3eaf to cc6961b9ac5e (3 revisions) (flutter/engine#23860)

* fdddf87 Roll Dart SDK from 1db2d4d95562 to 82b4c77fb17f (2 revisions) (flutter/engine#23861)
@iapicca iapicca mentioned this pull request Jan 24, 2021
Closed
@darshankawar darshankawar mentioned this pull request Jan 28, 2021
Closed
@iapicca iapicca mentioned this pull request Feb 6, 2021
Closed
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@hjfreyer
Automatically download Noto fonts as backup fonts in CanvasKit mode (f…
573c18a 
…lutter#23728)

* Revert "Revert "[CanvasKit] Automatically fall back to Noto fonts (flutter#23096)" (flutter#23357)"

This reverts commit f9f4d01.

* WIP

* Use an Interval Tree to store the unicode ranges for the Noto Fonts

* Update licenses

* Remove debug print statements

* Respond to comments

* Fix analysis error

* Add tests

* Respond to comments

* Fix test

* Update goldens lock

* Skip screenshot test on Safari

* Skip CanvasKit tests on iOS Safari

* Move CanvasKit initialization so it doesn't run on iOS Safari
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@ferhatb ferhatb ferhatb left review comments

@yjbanov yjbanov yjbanov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

4 participants

@harryterkelsen @yjbanov @ferhatb @googlebot