[iOS] Fixes DisplayLinkManager leaks #22194

zhongwuzw · 2020-10-29T08:03:44Z

Description

DisplayLinkManager retains display_link_, display_link_ retains the target (DisplayLinkManager) vice versa.

Related Issues

*N/A

Tests

I added the following tests:

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the contributor guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the C++, Objective-C, Java style guides for the engine.
I read the tree hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

I have submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

flutter-dashboard · 2020-10-29T08:03:46Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

chinmaygarde · 2020-11-12T23:27:41Z

shell/platform/darwin/ios/framework/Source/vsync_waiter_ios.mm

 @end

-@implementation DisplayLinkManager {
-  fml::scoped_nsobject<CADisplayLink> display_link_;


You still need to hold an ivar to the display link to invalidate it later. The display link retains the target and without invalidation, the back reference to it will not be cleared.

@chinmaygarde we release the display link https://github.com/flutter/engine/pull/22194/files#diff-ca0ba764dd3a3c6d10dfd05ea010d65973a4882b7f2549352367b97944a1fd8fR105, the reference to DisplayLinkManager would be nilled automatically.

The reference to the DisplayLinkManager will only be nilled when the display link is unscheduled from the event loop right? That won't happen till you invalidate the link. So it is not entirely automatic.

@chinmaygarde You're right, but we don't schedule the display link to runloop, and we also don't need invalidate it .

…lay_link_leaks

chinmaygarde

Apologies for the late reply. You are right about that display link not being scheduled. It is only used to figure out the supported display refresh rate. I'll rebase and land this. Thanks!

chinmaygarde · 2021-01-21T19:19:02Z

Hmm. I am unable to push the rebase to the branch. But it rebases cleanly. Landing.

* 5b2defd Roll Fuchsia Mac SDK from MrtHftV0U... to 7nZajqutF... (flutter/engine#23827) * c8ffb20 Roll Skia from 87a055b02027 to e0d023562bd9 (1 revision) (flutter/engine#23829) * 296902b implemented GetMainContext() for opengl (flutter/engine#23634) * 5cf3eae Roll Skia from e0d023562bd9 to 982127b7d57d (4 revisions) (flutter/engine#23831) * fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194) * b241537 Roll Fuchsia Linux Toolchain from git_revision:2c0536b76b35fa592ac7b4a0e4bb176eaf55af75 to IJxh_9dNS... (flutter/engine#23832) * 5c2003f Roll Skia from 982127b7d57d to 6de1e52d0b12 (1 revision) (flutter/engine#23834) * 5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKit mode (flutter/engine#23728) * 70a6824 Roll Dart SDK from 5e24a66b1bb8 to 704928da5702 (2 revisions) (flutter/engine#23838) * b0c46d8 Roll Skia from 6de1e52d0b12 to 8a37fb2c605b (5 revisions) (flutter/engine#23836) * d4132ea Use references when iterating over SkParagraph text boxes (flutter/engine#23837) * 87960d8 Fix typo in embedder unit tests (flutter/engine#23783) * 7f66714 iOS deeplink sends "path + query" instead of just path (flutter/engine#23562) * 1474d08 Roll Skia from 8a37fb2c605b to 37d16f135265 (4 revisions) (flutter/engine#23839) * 3da13fc Make android more lenient when it comes to out-of-order key event responses (flutter/engine#23604) * 9223073 Fix background crash when FlutterView going appear while app goes background (flutter/engine#23175) * 7c19824 Pass the filename directly to JNI for loading deferred component. (flutter/engine#23824) * 5dc2469 Reland path vol tracker (flutter/engine#23840) * e7e76f1 Roll Skia from 37d16f135265 to e89d8ea20b62 (2 revisions) (flutter/engine#23841) * 07f4861 Roll Dart SDK from 704928da5702 to 1db2d4d95562 (1 revision) (flutter/engine#23846) * 993ab78 Roll Skia from e89d8ea20b62 to c09761f57605 (1 revision) (flutter/engine#23843) * a4836a6 Call Dart plugin registrant if available (flutter/engine#23813) * 475a234 Roll Fuchsia Linux SDK from UGavhI1zv... to mODEe2CNk... (flutter/engine#23848) * b51da31 Roll Skia from c09761f57605 to 450f8565c7f3 (5 revisions) (flutter/engine#23851) * cb7106d Roll Skia from 450f8565c7f3 to 372791761157 (1 revision) (flutter/engine#23855) * 69980e5 Roll Fuchsia Mac SDK from 7nZajqutF... to tuJCioUf3... (flutter/engine#23857) * 20ff574 Roll Skia from 372791761157 to ce75036b3eaf (4 revisions) (flutter/engine#23858) * 0118b54 Implements accessibility bridge in common library (flutter/engine#23491) * ffc77f0 Search multiple paths when loading deferred component .so files. (flutter/engine#23849) * 71d264d Revert "implemented GetMainContext() for opengl (#23634)" (flutter/engine#23859) * fb48735 Roll Skia from ce75036b3eaf to cc6961b9ac5e (3 revisions) (flutter/engine#23860) * fdddf87 Roll Dart SDK from 1db2d4d95562 to 82b4c77fb17f (2 revisions) (flutter/engine#23861)

[iOS] Fixes DisplayLinkManager leaks

9b9f73c

flutter-dashboard bot added the platform-ios label Oct 29, 2020

google-cla bot added the cla: yes label Oct 29, 2020

chinmaygarde self-requested a review November 5, 2020 22:53

chinmaygarde suggested changes Nov 12, 2020

View reviewed changes

zhongwuzw added 2 commits November 21, 2020 12:03

Merge commit '66a6b4a56c7f0b926c0c637b300926f14c91d428' into fix_disp…

d89ac27

…lay_link_leaks

Remove unnecessary reset

17cbe33

zhongwuzw requested a review from chinmaygarde November 24, 2020 09:48

chinmaygarde approved these changes Jan 21, 2021

View reviewed changes

chinmaygarde merged commit fd9a079 into flutter:master Jan 21, 2021

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to 92230737069a (16 revisions) flutter/flutter#74457

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

7921c52

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to 7c19824c6d08 (17 revisions) flutter/flutter#74461

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

bca826e

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to 993ab786eeff (21 revisions) flutter/flutter#74474

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

a0e0570

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to 475a2349d53e (23 revisions) flutter/flutter#74478

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

fb68032

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to b51da31eb93c (24 revisions) flutter/flutter#74487

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

17f2192

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to cb7106dd7c39 (25 revisions) flutter/flutter#74501

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

3155ddc

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to 69980e5b8342 (26 revisions) flutter/flutter#74506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

3f39324

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to 20ff574d871d (27 revisions) flutter/flutter#74510

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

a28a762

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to ffc77f0da35b (29 revisions) flutter/flutter#74515

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

f6106c2

engine-flutter-autoroll mentioned this pull request Jan 22, 2021

Roll Engine from 90641fa92385 to fdddf8708039 (32 revisions) flutter/flutter#74517

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021

fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

3772f31

hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021

[iOS] Fixes DisplayLinkManager leaks (flutter#22194)

23efa3f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[iOS] Fixes DisplayLinkManager leaks #22194

[iOS] Fixes DisplayLinkManager leaks #22194

Uh oh!

zhongwuzw commented Oct 29, 2020

Uh oh!

flutter-dashboard bot commented Oct 29, 2020

Uh oh!

chinmaygarde Nov 12, 2020

Uh oh!

zhongwuzw Nov 13, 2020

Uh oh!

chinmaygarde Nov 20, 2020

Uh oh!

zhongwuzw Nov 21, 2020

Uh oh!

chinmaygarde left a comment

Uh oh!

chinmaygarde commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[iOS] Fixes DisplayLinkManager leaks #22194

[iOS] Fixes DisplayLinkManager leaks #22194

Uh oh!

Conversation

zhongwuzw commented Oct 29, 2020

Description

Related Issues

Tests

Checklist

Reviewer Checklist

Breaking Change

Uh oh!

flutter-dashboard bot commented Oct 29, 2020

Uh oh!

chinmaygarde Nov 12, 2020

Choose a reason for hiding this comment

Uh oh!

zhongwuzw Nov 13, 2020

Choose a reason for hiding this comment

Uh oh!

chinmaygarde Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

zhongwuzw Nov 21, 2020

Choose a reason for hiding this comment

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants