Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Call Dart plugin registrant if available #23813

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Call Dart plugin registrant if available #23813

merged 6 commits into from
Jan 22, 2021

Conversation

@blasten
Copy link

@blasten blasten commented Jan 20, 2021

The engine side of flutter/flutter#52267

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@blasten blasten force-pushed the dart_plugin_registrant branch from d04d415 to 9b1edbc Compare January 20, 2021 23:29
@blasten blasten marked this pull request as ready for review January 21, 2021 01:49
jason-simmons
jason-simmons reviewed Jan 21, 2021
View reviewed changes
@blasten blasten force-pushed the dart_plugin_registrant branch from 51cf1f0 to 5c7aa65 Compare January 21, 2021 20:13
@blasten blasten force-pushed the dart_plugin_registrant branch from 5c7aa65 to fb0502a Compare January 21, 2021 20:16
chinmaygarde
chinmaygarde approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks correct but I am not sure why the native resolver is failing. You should be able to set a breakpoint at the point of failure though.

@blasten blasten force-pushed the dart_plugin_registrant branch from b2e3d34 to d6e6638 Compare January 21, 2021 23:37
@blasten
Copy link
Author

blasten commented Jan 21, 2021

I had to introduce a new flag inSetting, so the new behavior can be turn on from the test. Otherwise, other runtime tests fail due to the undefined native call PassMessageForDartRegistrantTest.

@blasten blasten force-pushed the dart_plugin_registrant branch from d6e6638 to 3d896ad Compare January 21, 2021 23:39
@blasten blasten force-pushed the dart_plugin_registrant branch from 3d896ad to 9b36745 Compare January 22, 2021 00:58
@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 22, 2021
@fluttergithubbot fluttergithubbot merged commit a4836a6 into flutter:master Jan 22, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)
e396312
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)
5fbca03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)
227f236
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)
4e3f686
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)
e5991b0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)
5c9be68
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 22, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 22, 2021
@engine-flutter-autoroll
a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)
90a9ec8
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 23, 2021
@engine-flutter-autoroll
Roll Engine from 90641fa to fdddf87 (32 revisions) (#74517)
ea3aa67 
* 5b2defd Roll Fuchsia Mac SDK from MrtHftV0U... to 7nZajqutF... (flutter/engine#23827)

* c8ffb20 Roll Skia from 87a055b02027 to e0d023562bd9 (1 revision) (flutter/engine#23829)

* 296902b implemented GetMainContext() for opengl (flutter/engine#23634)

* 5cf3eae Roll Skia from e0d023562bd9 to 982127b7d57d (4 revisions) (flutter/engine#23831)

* fd9a079 [iOS] Fixes DisplayLinkManager leaks (flutter/engine#22194)

* b241537 Roll Fuchsia Linux Toolchain from git_revision:2c0536b76b35fa592ac7b4a0e4bb176eaf55af75 to IJxh_9dNS... (flutter/engine#23832)

* 5c2003f Roll Skia from 982127b7d57d to 6de1e52d0b12 (1 revision) (flutter/engine#23834)

* 5b9cd44 Automatically download Noto fonts as backup fonts in CanvasKit mode (flutter/engine#23728)

* 70a6824 Roll Dart SDK from 5e24a66b1bb8 to 704928da5702 (2 revisions) (flutter/engine#23838)

* b0c46d8 Roll Skia from 6de1e52d0b12 to 8a37fb2c605b (5 revisions) (flutter/engine#23836)

* d4132ea Use references when iterating over SkParagraph text boxes (flutter/engine#23837)

* 87960d8 Fix typo in embedder unit tests (flutter/engine#23783)

* 7f66714 iOS deeplink sends "path + query" instead of just path (flutter/engine#23562)

* 1474d08 Roll Skia from 8a37fb2c605b to 37d16f135265 (4 revisions) (flutter/engine#23839)

* 3da13fc Make android more lenient when it comes to out-of-order key event responses (flutter/engine#23604)

* 9223073 Fix background crash when FlutterView going appear while app goes background (flutter/engine#23175)

* 7c19824 Pass the filename directly to JNI for loading deferred component. (flutter/engine#23824)

* 5dc2469 Reland path vol tracker (flutter/engine#23840)

* e7e76f1 Roll Skia from 37d16f135265 to e89d8ea20b62 (2 revisions) (flutter/engine#23841)

* 07f4861 Roll Dart SDK from 704928da5702 to 1db2d4d95562 (1 revision) (flutter/engine#23846)

* 993ab78 Roll Skia from e89d8ea20b62 to c09761f57605 (1 revision) (flutter/engine#23843)

* a4836a6 Call Dart plugin registrant if available (flutter/engine#23813)

* 475a234 Roll Fuchsia Linux SDK from UGavhI1zv... to mODEe2CNk... (flutter/engine#23848)

* b51da31 Roll Skia from c09761f57605 to 450f8565c7f3 (5 revisions) (flutter/engine#23851)

* cb7106d Roll Skia from 450f8565c7f3 to 372791761157 (1 revision) (flutter/engine#23855)

* 69980e5 Roll Fuchsia Mac SDK from 7nZajqutF... to tuJCioUf3... (flutter/engine#23857)

* 20ff574 Roll Skia from 372791761157 to ce75036b3eaf (4 revisions) (flutter/engine#23858)

* 0118b54 Implements accessibility bridge in common library (flutter/engine#23491)

* ffc77f0 Search multiple paths when loading deferred component .so files. (flutter/engine#23849)

* 71d264d Revert "implemented GetMainContext() for opengl (#23634)" (flutter/engine#23859)

* fb48735 Roll Skia from ce75036b3eaf to cc6961b9ac5e (3 revisions) (flutter/engine#23860)

* fdddf87 Roll Dart SDK from 1db2d4d95562 to 82b4c77fb17f (2 revisions) (flutter/engine#23861)
@blasten blasten deleted the dart_plugin_registrant branch January 26, 2021 19:14
@jonahwilliams jonahwilliams mentioned this pull request Mar 18, 2021
Closed
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@hjfreyer
Call Dart plugin registrant if available (flutter#23813)
71d6b82
zanderso added a commit that referenced this pull request Mar 24, 2021
@zanderso
Revert "Call Dart plugin registrant if available (#23813)"
1c6d75e 
This reverts commit a4836a6.
@zanderso zanderso mentioned this pull request Mar 24, 2021
Closed
zanderso added a commit that referenced this pull request Mar 24, 2021
@zanderso
Revert "Call Dart plugin registrant if available (#23813)"
8cb234e 
This reverts commit a4836a6.
@zanderso zanderso mentioned this pull request Mar 24, 2021
Merged
fluttergithubbot pushed a commit that referenced this pull request Mar 25, 2021
@zanderso
Revert "Call Dart plugin registrant if available (#23813)" (#25221)
15b20ee
chandarrengoog pushed a commit to chandarrengoog/engine that referenced this pull request Mar 30, 2021
@zanderso @chandarrengoog
Revert "Call Dart plugin registrant if available (flutter#23813)" (fl…
1b44528 
…utter#25221)
blasten pushed a commit to blasten/engine that referenced this pull request Apr 2, 2021
Revert "Revert "Call Dart plugin registrant if available (flutter#23813…
b4c0ba2 
…)" (flutter#25221)"

This reverts commit 15b20ee.
@blasten blasten mentioned this pull request Apr 8, 2021
Merged
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@zanderso @duanqz
Revert "Call Dart plugin registrant if available (flutter#23813)" (fl…
5fcadc6 
…utter#25221)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@jason-simmons jason-simmons jason-simmons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blasten @chinmaygarde @jason-simmons @googlebot @fluttergithubbot