This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[CanvasKit] Automatically fall back to Noto fonts (#23096)" #23357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit eff27c7. Reason for revert: Incorrect logic breaks Gallery
|
Submitting without LGTM as it seems everyone is out of town and this PR is causing breakages. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 3, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 5, 2021
)" (flutter#23357) This reverts commit eff27c7. Reason for revert: Incorrect logic breaks Gallery
yjbanov
pushed a commit
to yjbanov/engine
that referenced
this pull request
Jan 7, 2021
)" (flutter#23357) This reverts commit eff27c7. Reason for revert: Incorrect logic breaks Gallery
harryterkelsen
added a commit
to harryterkelsen/engine
that referenced
this pull request
Jan 15, 2021
…utter#23096)" (flutter#23357)" This reverts commit f9f4d01.
harryterkelsen
pushed a commit
that referenced
this pull request
Jan 21, 2021
…23728) * Revert "Revert "[CanvasKit] Automatically fall back to Noto fonts (#23096)" (#23357)" This reverts commit f9f4d01. * WIP * Use an Interval Tree to store the unicode ranges for the Noto Fonts * Update licenses * Remove debug print statements * Respond to comments * Fix analysis error * Add tests * Respond to comments * Fix test * Update goldens lock * Skip screenshot test on Safari * Skip CanvasKit tests on iOS Safari * Move CanvasKit initialization so it doesn't run on iOS Safari
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
…lutter#23728) * Revert "Revert "[CanvasKit] Automatically fall back to Noto fonts (flutter#23096)" (flutter#23357)" This reverts commit f9f4d01. * WIP * Use an Interval Tree to store the unicode ranges for the Noto Fonts * Update licenses * Remove debug print statements * Respond to comments * Fix analysis error * Add tests * Respond to comments * Fix test * Update goldens lock * Skip screenshot test on Safari * Skip CanvasKit tests on iOS Safari * Move CanvasKit initialization so it doesn't run on iOS Safari
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit eff27c7.
Reason for revert: Incorrect logic breaks Gallery