Skip to content

Conversation

@idegtiarenko
Copy link
Contributor

No description provided.

@idegtiarenko idegtiarenko added :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels Jun 22, 2022
@idegtiarenko idegtiarenko requested a review from DaveCTurner June 22, 2022 14:38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that's enough - IIRC deleting an index may trigger another reroute but it doesn't wait for that reroute to complete.

@idegtiarenko idegtiarenko requested a review from DaveCTurner July 8, 2022 10:46
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but should we make this change in master first?

@idegtiarenko
Copy link
Contributor Author

Looks good, but should we make this change in master first?

Okay, let me change the base for this pr

@idegtiarenko idegtiarenko changed the base branch from feature/desired-balance-allocator to master July 8, 2022 11:58
@idegtiarenko idegtiarenko changed the base branch from master to feature/desired-balance-allocator July 8, 2022 11:58
@idegtiarenko idegtiarenko force-pushed the fix_rare_cluster_state_it branch from 0dda1bc to 388d3a6 Compare July 8, 2022 12:10
@idegtiarenko idegtiarenko changed the base branch from feature/desired-balance-allocator to master July 8, 2022 12:10
@idegtiarenko
Copy link
Contributor Author

Done, this is now targeting master

@idegtiarenko idegtiarenko requested a review from DaveCTurner July 8, 2022 12:10
@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests v8.4.0 labels Jul 8, 2022
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@idegtiarenko idegtiarenko merged commit ae53fab into elastic:master Jul 11, 2022
@idegtiarenko idegtiarenko deleted the fix_rare_cluster_state_it branch July 11, 2022 06:06
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 12, 2022
* upstream/master:
  Pass IndexMetadata to AllocationDecider.can_remain (elastic#88453)
  [TSDB] Cache rollup bucket timestamp to reduce rounding cost (elastic#88420)
  Correct some typos/mistakes in comments/docs (elastic#88446)
  Make ClusterInfo use immutable maps in all cases (elastic#88447)
  Reduce map lookups (elastic#88418)
  Don't index geo_shape field in AbstractBuilderTestCase (elastic#88437)
  Remove usages of TestGeoShapeFieldMapperPlugin from enrich module (elastic#88440)
  Fix test memory leak (elastic#88362)
  Improve error when sorting on incompatible types (elastic#88399)
  Remove usages of BucketCollector#getLeafCollector(LeafReaderContext) (elastic#88414)
  Mute ReactiveStorageIT::testScaleWhileShrinking (elastic#88431)
  Clarify snapshot docs on archive indices (elastic#88417)
  [Stack Monitoring] Switch cgroup memory fields to keyword (elastic#88260)
  Fix RealmIdentifier XContent parser (elastic#88410)
  Make LoggedExec gradle task configuration cache compatible (elastic#87621)
  Update CorruptedFileIT so that it passes with new allocation strategy (elastic#88314)
  Update RareClusterStateIT to work with the new shards allocator (elastic#87922)
  Ensure CreateApiKey always creates a new document (elastic#88413)

# Conflicts:
#	x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/RollupShardIndexer.java
pxsalehi added a commit to pxsalehi/elasticsearch that referenced this pull request Oct 6, 2022
pxsalehi added a commit that referenced this pull request Oct 18, 2022
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 3, 2022
Reverts elastic#90720 and adds some additional logging to further investigate
the failure here.

Relates elastic#87922
DaveCTurner added a commit that referenced this pull request Nov 3, 2022
Reverts #90720 and fixes the race which caused the test failure.

Relates #87922
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants