Update CorruptedFileIT so that it passes with new allocation strategy #88314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New allocation strategy is not going to retry failed shards. Update the test to not rely on that behaviour
idegtiarenko
added
>test
Contributor
Author
|
Just confirmed this also passes on the feature branch |
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/part-2 |
DaveCTurner
reviewed
Jul 6, 2022
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Looks good, I left a couple of comments.
| .put("index.routing.allocation.include._name", primariesNode.getName() + "," + unluckyNode.getName()) | ||
| ) | ||
| .get(); | ||
| ensureYellow("test"); |
Contributor
There was a problem hiding this comment.
Hmm this would pass even if the index reaches green health. I think we want to wait for no initialising shards and then genuinely assert that none of the shards are on the unlucky node.
Contributor
Author
There was a problem hiding this comment.
I believe this call is waiting for no initializing shards internally. Added more detailed assertion below.
UPD: actually it is not, fixing...
server/src/internalClusterTest/java/org/elasticsearch/index/store/CorruptedFileIT.java
Show resolved
Hide resolved
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jul 12, 2022
* upstream/master: Pass IndexMetadata to AllocationDecider.can_remain (elastic#88453) [TSDB] Cache rollup bucket timestamp to reduce rounding cost (elastic#88420) Correct some typos/mistakes in comments/docs (elastic#88446) Make ClusterInfo use immutable maps in all cases (elastic#88447) Reduce map lookups (elastic#88418) Don't index geo_shape field in AbstractBuilderTestCase (elastic#88437) Remove usages of TestGeoShapeFieldMapperPlugin from enrich module (elastic#88440) Fix test memory leak (elastic#88362) Improve error when sorting on incompatible types (elastic#88399) Remove usages of BucketCollector#getLeafCollector(LeafReaderContext) (elastic#88414) Mute ReactiveStorageIT::testScaleWhileShrinking (elastic#88431) Clarify snapshot docs on archive indices (elastic#88417) [Stack Monitoring] Switch cgroup memory fields to keyword (elastic#88260) Fix RealmIdentifier XContent parser (elastic#88410) Make LoggedExec gradle task configuration cache compatible (elastic#87621) Update CorruptedFileIT so that it passes with new allocation strategy (elastic#88314) Update RareClusterStateIT to work with the new shards allocator (elastic#87922) Ensure CreateApiKey always creates a new document (elastic#88413) # Conflicts: # x-pack/plugin/rollup/src/main/java/org/elasticsearch/xpack/rollup/v2/RollupShardIndexer.java
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jul 20, 2022
`POST _cluster/reroute?retry_failed` doesn't reset the failure counter on any `INITIALIZING` shards, and waiting for no `INITIALIZING` shards isn't quite enough to ensure that we've finished all possible retries because there could instead be an ongoing async fetch. This commit fixes this using a `ClusterStateObserver` to observe the retry counter instead of using the cluster health action. Relates elastic#88314 Closes elastic#88615
DaveCTurner
added a commit
that referenced
this pull request
Jul 20, 2022
`POST _cluster/reroute?retry_failed` doesn't reset the failure counter on any `INITIALIZING` shards, and waiting for no `INITIALIZING` shards isn't quite enough to ensure that we've finished all possible retries because there could instead be an ongoing async fetch. This commit fixes this using a `ClusterStateObserver` to observe the retry counter instead of using the cluster health action. Relates #88314 Closes #88615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New allocation strategy is not going to retry failed shards. Update the
test to not rely on that behavior
Rel: #86429