Reinstate "Update RareClusterStateIT to work with ... (#87922)" #91272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverts elastic#90720 and adds some additional logging to further investigate the failure here. Relates elastic#87922
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
idegtiarenko
reviewed
Nov 3, 2022
| + "]"; | ||
| assertEquals("[null,null]", results); | ||
| assertFalse(putMappingResponse.isDone()); | ||
| assertFalse(docIndexResponse.isDone()); |
Contributor
There was a problem hiding this comment.
It looks like there is no way with hamcrest to combine multiple assertions on different objects into one.
Looks like another reason to use assertj: https://stackoverflow.com/questions/47397525/multiply-conditions-set-in-assertj-assertions
idegtiarenko
approved these changes
Nov 3, 2022
Member
|
This seems to still fail (at least for me): https://gradle-enterprise.elastic.co/s/hs6e6lwwd6kou |
Contributor
Author
Member
|
Not anymore! 😃 🎉 |
Contributor
Author
|
Great, thanks for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #90720 and adds some additional logging to further investigate the failure here.
Relates #87922