Skip to content

Revert "Update RareClusterStateIT to work with ... (#87922)" #90720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2022
Merged

Revert "Update RareClusterStateIT to work with ... (#87922)" #90720

merged 1 commit into from
Oct 18, 2022

Conversation

@pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Oct 6, 2022 •
edited
Loading

The changes in the reverted commit are only to the a portion of the test (setup) itself. They have failed fairly often despite a previous attempt to fix the new test addition in #62662.

Running the test suite with:

./gradlew ':server:internalClusterTest' --tests "org.elasticsearch.cluster.coordination.RareClusterStateIT" -Dtests.seed=96C138A4D5D7BA40 -Dtests.locale=el-CY -Dtests.timezone=Australia/ACT -Druntime.java=17 -Dtests.iters=200 -Dtests.random=$RANDOM

(and even more runs), the suite seems to be more stable w/o the changes. What was the reason for those code changes?

Closes #89905

@pxsalehi pxsalehi added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v7.17.7 v8.5.1 labels Oct 6, 2022
@pxsalehi pxsalehi requested a review from idegtiarenko October 6, 2022 15:10
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 6, 2022

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.6.0 labels Oct 6, 2022
@benwtrent benwtrent added v7.17.8 and removed v7.17.7 labels Oct 13, 2022
@pxsalehi
Copy link
Member Author

pxsalehi commented Oct 18, 2022

Thanks @idegtiarenko

@pxsalehi pxsalehi merged commit eeeb79d into elastic:main Oct 18, 2022
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Nov 3, 2022
@DaveCTurner
Reinstate "Update RareClusterStateIT to work with ... (elastic#87922)"
a71c676 
Reverts elastic#90720 and adds some additional logging to further investigate
the failure here.

Relates elastic#87922
@DaveCTurner DaveCTurner mentioned this pull request Nov 3, 2022
Merged
DaveCTurner added a commit that referenced this pull request Nov 3, 2022
@DaveCTurner
Reinstate "Update RareClusterStateIT to work with ... (#87922)" (#91272)
c6630ac 
Reverts #90720 and fixes the race which caused the test failure.

Relates #87922
@csoulios csoulios added v8.5.0 and removed v8.5.1 labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@idegtiarenko idegtiarenko idegtiarenko approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.17.8 v8.5.0 v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI] RareClusterStateIT testDelayedMappingPropagationOnReplica failing

5 participants

@pxsalehi @elasticsearchmachine @idegtiarenko @csoulios @benwtrent