Fix testMasterStatsOnSuccessfulUpdate #76844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test advances time in surprising places, so we have to allow a little longer for publication or stabilisation to complete. Closes elastic#76840
DaveCTurner
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
|
@DaveCTurner ah sorry I forgot, you forgot to reenable the test here I think? :) |
Contributor
Author
|
That's a good way to get CI to go green, but no I did remove the |
DaveCTurner
added
auto-backport
Contributor
|
Thanks David! + sorry for my brain looking for the -AwaitsFix on the right hand side of the diff :) |
DaveCTurner
deleted the
2021-08-23-fix-testMasterStatsOnSuccessfulUpdate
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 23, 2021
This test advances time in surprising places, so we have to allow a little longer for publication or stabilisation to complete. Closes elastic#76840
Collaborator
💚 Backport successful
|
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 23, 2021
Legacy "zen" discovery doesn't record any timing stats, but these stats are required. Fixes this by recording zeroes for everything. Closes elastic#76844
Merged
DaveCTurner
added a commit
that referenced
this pull request
Aug 23, 2021
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Aug 24, 2021
* master: (21 commits) [Test] More robust assertions for sorting and pagination (elastic#76654) [Test] Fix filename check on Windows (elastic#76807) Upgrade build scan plugin to 3.6.4 (elastic#76784) Remove keystore initial_md5sum (elastic#76835) Don't export docker images on assemble (elastic#76817) Fix testMasterStatsOnSuccessfulUpdate (elastic#76844) AwaitsFix for elastic#76840 Make Releasing Aggregation Buffers Safer (elastic#76741) Re-enable BWC tests after backport of elastic#76771 (elastic#76839) Dispatch large bulk requests to write thread (elastic#76736) Disable BWC tests for elastic#76771 Pull down beats artifacts when performing release tests Add timing stats to publication process (elastic#76771) Fix BanFailureLoggingTests some more (elastic#76668) Mention "warn threshold" in master service slowlog (elastic#76815) Fix DockerTests.test010Install Re-enable tests affected by elastic#75097 (elastic#76814) Fix testRecoveryIsCancelledAfterDeletingTheIndex (elastic#76644) Test fix -WildcardFieldMapperTests bad test data. (elastic#76819) Updating supported version after backporting the feature (elastic#76794) ... # Conflicts: # server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
DaveCTurner
added a commit
that referenced
this pull request
Aug 24, 2021
Legacy "zen" discovery doesn't record any timing stats, but these stats are required. Fixes this by recording zeroes for everything. Closes #76844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test advances time in surprising places, so we have to allow a
little longer for publication or stabilisation to complete.
Closes #76840