Dispatch large bulk requests to write thread #76736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all of the coordinating action for a bulk request is performed on the transport thread. With Elasticsearch increasing its usage of compression, it is now possible that large bulk requests will be compressed at the coordinating stage when routing to other nodes. This commit moves the coordination of large bulk requsets to the write thread to avoid blocking the transport threads on costly CPU operations.
Tim-Brooks
added
>non-issue
:Distributed Indexing/CRUD
elasticmachine
added
the
Team:Distributed (Obsolete)
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Aug 23, 2021
| public class TransportBulkAction extends HandledTransportAction<BulkRequest, BulkResponse> { | ||
|
|
||
| private static final Logger logger = LogManager.getLogger(TransportBulkAction.class); | ||
| private static final long ONE_MEGABYTE = ByteSizeValue.ofMb(1).getBytes(); |
Contributor
There was a problem hiding this comment.
nit: I prefer ByteSizeUnit.MB.toBytes(1), seems more direct. But it is mostly a preference so optional.
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Outdated
Show resolved
Hide resolved
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Aug 24, 2021
* master: (21 commits) [Test] More robust assertions for sorting and pagination (elastic#76654) [Test] Fix filename check on Windows (elastic#76807) Upgrade build scan plugin to 3.6.4 (elastic#76784) Remove keystore initial_md5sum (elastic#76835) Don't export docker images on assemble (elastic#76817) Fix testMasterStatsOnSuccessfulUpdate (elastic#76844) AwaitsFix for elastic#76840 Make Releasing Aggregation Buffers Safer (elastic#76741) Re-enable BWC tests after backport of elastic#76771 (elastic#76839) Dispatch large bulk requests to write thread (elastic#76736) Disable BWC tests for elastic#76771 Pull down beats artifacts when performing release tests Add timing stats to publication process (elastic#76771) Fix BanFailureLoggingTests some more (elastic#76668) Mention "warn threshold" in master service slowlog (elastic#76815) Fix DockerTests.test010Install Re-enable tests affected by elastic#75097 (elastic#76814) Fix testRecoveryIsCancelledAfterDeletingTheIndex (elastic#76644) Test fix -WildcardFieldMapperTests bad test data. (elastic#76819) Updating supported version after backporting the feature (elastic#76794) ... # Conflicts: # server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Tim-Brooks
added a commit
that referenced
this pull request
Sep 29, 2021
Currently all of the coordinating action for a bulk request is performed on the transport thread. With Elasticsearch increasing its usage of compression, it is now possible that large bulk requests will be compressed at the coordinating stage when routing to other nodes. This commit moves the coordination of large bulk requsets to the write thread to avoid blocking the transport threads on costly CPU operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all of the coordinating action for a bulk request is performed
on the transport thread. With Elasticsearch increasing its usage of
compression, it is now possible that large bulk requests will be
compressed at the coordinating stage when routing to other nodes. This
commit moves the coordination of large bulk requsets to the write thread
to avoid blocking the transport threads on costly CPU operations.