Don't export docker images on assemble #76817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our packaging tests set up dependencies so that the tests depend on the artifact that is going to be tested. For Docker, the tests depend on an export of the Docker image, partly to follow the pattern, but partly to support loading the image when the tests are executed inside Vagrant. There is a sub-project for each type of image that can be exported. The main Docker build file adds an export task and an artifact to the sub-project. However, it also makes the export task a dependency of the sub-project's `assemble` task. This last step isn't necessary for the tests to run, and causes extra and needless work to be done when running `assemble` on the entire build. Therefore, removing the last bit of task wiring.
pugnascotia
added
>enhancement
:Delivery/Build
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
added
the
auto-merge-without-approval
Member
|
@mark-vieira @breskeby could you please look into this so we can unblock our ES Snapshots CI for Kibana please? 😃 |
mark-vieira
approved these changes
Aug 23, 2021
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
Sounds good. I saw this recently and thought it was necessary for release manager, but that only depends on the docker context tasks. LGTM.
pugnascotia
added a commit
that referenced
this pull request
Aug 23, 2021
Our packaging tests set up dependencies so that the tests depend on the artifact that is going to be tested. For Docker, the tests depend on an export of the Docker image, partly to follow the pattern, but partly to support loading the image when the tests are executed inside Vagrant. There is a sub-project for each type of image that can be exported. The main Docker build file adds an export task and an artifact to the sub-project. However, it also makes the export task a dependency of the sub-project's `assemble` task. This last step isn't necessary for the tests to run, and causes extra and needless work to be done when running `assemble` on the entire build. Therefore, removing the last bit of task wiring.
Contributor
Author
|
Backported to |
wjp719
added a commit
to wjp719/elasticsearch
that referenced
this pull request
Aug 24, 2021
* master: (21 commits) [Test] More robust assertions for sorting and pagination (elastic#76654) [Test] Fix filename check on Windows (elastic#76807) Upgrade build scan plugin to 3.6.4 (elastic#76784) Remove keystore initial_md5sum (elastic#76835) Don't export docker images on assemble (elastic#76817) Fix testMasterStatsOnSuccessfulUpdate (elastic#76844) AwaitsFix for elastic#76840 Make Releasing Aggregation Buffers Safer (elastic#76741) Re-enable BWC tests after backport of elastic#76771 (elastic#76839) Dispatch large bulk requests to write thread (elastic#76736) Disable BWC tests for elastic#76771 Pull down beats artifacts when performing release tests Add timing stats to publication process (elastic#76771) Fix BanFailureLoggingTests some more (elastic#76668) Mention "warn threshold" in master service slowlog (elastic#76815) Fix DockerTests.test010Install Re-enable tests affected by elastic#75097 (elastic#76814) Fix testRecoveryIsCancelledAfterDeletingTheIndex (elastic#76644) Test fix -WildcardFieldMapperTests bad test data. (elastic#76819) Updating supported version after backporting the feature (elastic#76794) ... # Conflicts: # server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our packaging tests set up dependencies so that the tests depend on the
artifact that is going to be tested. For Docker, the tests depend on an
export of the Docker image, partly to follow the pattern, but partly to
support loading the image when the tests are executed inside Vagrant.
There is a sub-project for each type of image that can be exported. The
main Docker build file adds an export task and an artifact to the
sub-project. However, it also makes the export task a dependency of the
sub-project's
assembletask. This last step isn't necessary for thetests to run, and causes extra and needless work to be done when running
assembleon the entire build. Therefore, removing the last bit of taskwiring.