Skip to content

Commit 51b0c0c

Browse files
authored
Don't export docker images on assemble (#76817)
Our packaging tests set up dependencies so that the tests depend on the artifact that is going to be tested. For Docker, the tests depend on an export of the Docker image, partly to follow the pattern, but partly to support loading the image when the tests are executed inside Vagrant. There is a sub-project for each type of image that can be exported. The main Docker build file adds an export task and an artifact to the sub-project. However, it also makes the export task a dependency of the sub-project's `assemble` task. This last step isn't necessary for the tests to run, and causes extra and needless work to be done when running `assemble` on the entire build. Therefore, removing the last bit of task wiring.
1 parent 007b5ae commit 51b0c0c

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

distribution/docker/build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -469,9 +469,5 @@ subprojects { Project subProject ->
469469
name artifactName
470470
builtBy exportTaskName
471471
}
472-
473-
tasks.named("assemble").configure {
474-
dependsOn(exportTaskName)
475-
}
476472
}
477473
}

0 commit comments

Comments
 (0)