Remove Needless Sleeps on Node Configuration Changes in Internal Cluster Tests (#76884) #76908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter Tests (elastic#76884) I noticed this recently when trying to reproduce a test failure. We're doing a lot of sleeping when validating that the cluster formed if that process is slow randomly (which it tends to be due to disk interaction on node starts and such.). By reusing the approach for waiting on a cluster state we rarely if ever need to get into the busy assert loop and remove all these sleeps, shaving of a few seconds here and there from running internal cluster tests.
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
original-brownbear
added
the
>test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this recently when trying to reproduce a test failure. We're doing a lot of sleeping
when validating that the cluster formed if that process is slow randomly (which it tends to be
due to disk interaction on node starts and such.). By reusing the approach for waiting on a
cluster state we rarely if ever need to get into the busy assert loop and remove all these sleeps,
shaving of a few seconds here and there from running internal cluster tests.
backport of #76884