Fix Eclipse compilation problems #26170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
changed the title
Member
|
LGTM but I think you should add a comment explaining why you've pulled the lists out. If you can reference the eclipse bug that'd be even butter. I don't know which bug it is. It is fixed in Oxygen though. |
cbuescher
force-pushed
the
fix-eclipse-compileIssues
branch
from
8e325fe to
dc2d406
Compare
Member
Author
|
@nik9000 thanks, I added a comment |
cbuescher
added a commit
that referenced
this pull request
Aug 13, 2017
cbuescher
added a commit
that referenced
this pull request
Aug 13, 2017
Member
|
Are we going to move away from supporting Eclipse Neon so we stop having to make these changes? |
Member
Author
|
Yes, I also changed to Oxygen now. Hope it works better in cases like these. |
Member
|
I opened #26194. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 14, 2017
* master: (30 commits) Rewrite range queries with open bounds to exists query (elastic#26160) Fix eclipse compilation problem (elastic#26170) Epoch millis and second formats parse float implicitly (Closes elastic#14641) (elastic#26119) fix SplitProcessor targetField test (elastic#26178) Fixed typo in README.textile (elastic#26168) Fix incorrect class name in deleteByQuery docs (elastic#26151) Move more token filters to analysis-common module reindex: automatically choose the number of slices (elastic#26030) Fix serialization of the `_all` field. (elastic#26143) percolator: Hint what clauses are important in a conjunction query based on fields Remove unused Netty-related settings (elastic#26161) Remove SimpleQueryStringIT#testPhraseQueryOnFieldWithNoPositions. Tests: reenable ShardReduceIT#testIpRange. Allow `ClusterState.Custom` to be created on initial cluster states (elastic#26144) Teach the build about betas and rcs (elastic#26066) Fix wrong header level inner hits: Unfiltered nested source should keep its full path Document how to import Lucene Snapshot libs when elasticsearch clients (elastic#26113) Use `global_ordinals_hash` execution mode when sorting by sub aggregations. (elastic#26014) Make the README use a single type in examples. (elastic#26098) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eclipse is not so good at doing type inference inside lambdas it seems. The class compiles well using the java compile but Eclipse compiler complains. This change just pulls out the argument into a local variable to avoid the problem.