Remove unused Netty-related settings #26161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we remove the two previously unused Netty 4 related settings `transport.netty.max_cumulation_buffer_capacity` and `transport.netty.max_composite_buffer_components` from Elasticsearch.
danielmitterdorfer
added
:Distributed Coordination/Network
jpountz
approved these changes
Aug 11, 2017
danielmitterdorfer
added a commit
that referenced
this pull request
Aug 11, 2017
With this commit we remove the following three previously unused (and undocumented) Netty 4 related settings: * transport.netty.max_cumulation_buffer_capacity, * transport.netty.max_composite_buffer_components and * http.netty.max_cumulation_buffer_capacity from Elasticsearch.
danielmitterdorfer
added a commit
that referenced
this pull request
Aug 11, 2017
With this commit we remove the following three previously unused (and undocumented) Netty 4 related settings: * transport.netty.max_cumulation_buffer_capacity, * transport.netty.max_composite_buffer_components and * http.netty.max_cumulation_buffer_capacity from Elasticsearch.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 14, 2017
* master: (30 commits) Rewrite range queries with open bounds to exists query (elastic#26160) Fix eclipse compilation problem (elastic#26170) Epoch millis and second formats parse float implicitly (Closes elastic#14641) (elastic#26119) fix SplitProcessor targetField test (elastic#26178) Fixed typo in README.textile (elastic#26168) Fix incorrect class name in deleteByQuery docs (elastic#26151) Move more token filters to analysis-common module reindex: automatically choose the number of slices (elastic#26030) Fix serialization of the `_all` field. (elastic#26143) percolator: Hint what clauses are important in a conjunction query based on fields Remove unused Netty-related settings (elastic#26161) Remove SimpleQueryStringIT#testPhraseQueryOnFieldWithNoPositions. Tests: reenable ShardReduceIT#testIpRange. Allow `ClusterState.Custom` to be created on initial cluster states (elastic#26144) Teach the build about betas and rcs (elastic#26066) Fix wrong header level inner hits: Unfiltered nested source should keep its full path Document how to import Lucene Snapshot libs when elasticsearch clients (elastic#26113) Use `global_ordinals_hash` execution mode when sorting by sub aggregations. (elastic#26014) Make the README use a single type in examples. (elastic#26098) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we remove the three previously unused Netty 4 related settings
transport.netty.max_cumulation_buffer_capacity,transport.netty.max_composite_buffer_componentsandhttp.netty.max_cumulation_buffer_capacityfrom Elasticsearch.As this is a breaking change (we remove settings), I'd like to get this in for 6.0, otherwise we need to keep them around until 7.0. However, as they were unused (and undocumented) previously I think the risk is low.