-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Clarify IDE versions #26194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify IDE versions #26194
Conversation
This commit clarifies the minimum IDE versions that we support for development. We need to formally state that the minimum that we support for Eclipse is Eclipse Oxygen because Eclipse Neon and prior releases have type inference bugs that lead to compilation issues that cause us to have to contort our code to support Eclipse and it appears that Eclipse Oxygen is less-prone to these issue. And the recent high-level REST shading work seems to work best in Intellij 2017.2. Therefore, we state these versions explicitly.
| Elasticsearch uses it as its build system. Gradle must be at least | ||
| version 3.3 in order to build successfully. | ||
|
|
||
| We support development in the Eclipse and IntelliJ IDEs. For Eclipse, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should go as far as to say we "support" this, since we didn't have any promise attached to it so far. Is "suggest" too vague here? And saying that these are the minimum versions we test with ourselves? Just my 2 cent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should say "support". If contributors/users have trouble in one of these two IDEs, then we as developers will help them, and we as developers will ensure that development in Elasticsearch can be done in one of these two IDEs. If they try to use any other IDE (e.g., Netbeans) we are not going to be able to help, nor guarantee that such development will always work. This encompasses the definition of "support" IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "support" is right.
| Elasticsearch uses it as its build system. Gradle must be at least | ||
| version 3.3 in order to build successfully. | ||
|
|
||
| We support development in the Eclipse and IntelliJ IDEs. For Eclipse, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "support" is right.
|
Thanks @cbuescher and @nik9000. |
This commit clarifies the minimum IDE versions that we support for development. We need to formally state that the minimum that we support for Eclipse is Eclipse Oxygen because Eclipse Neon and prior releases have type inference bugs that lead to compilation issues that cause us to have to contort our code to support Eclipse and it appears that Eclipse Oxygen is less-prone to these issue. And the recent high-level REST shading work seems to work best in Intellij 2017.2. Therefore, we state these versions explicitly.