Fix serialization of the _all field.
#26143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we only serialize analyzers if the index analyzer is not the `default` analyzer or if the `search_analyzer` is different from the index `analyzer`. This raises issues with the `_all` field when the `index.analysis.analyzer.default_search` is set, since it automatically makes the `search_analyzer` different from the index `analyzer`. Then there are exceptions since we expect the `_all` configuration to be empty on 6.0 indices. Closes elastic#26136
jpountz
added
:Search Foundations/Mapping
jpountz
added a commit
that referenced
this pull request
Aug 11, 2017
By default we only serialize analyzers if the index analyzer is not the `default` analyzer or if the `search_analyzer` is different from the index `analyzer`. This raises issues with the `_all` field when the `index.analysis.analyzer.default_search` is set, since it automatically makes the `search_analyzer` different from the index `analyzer`. Then there are exceptions since we expect the `_all` configuration to be empty on 6.0 indices. Closes #26136
jpountz
added a commit
that referenced
this pull request
Aug 11, 2017
By default we only serialize analyzers if the index analyzer is not the `default` analyzer or if the `search_analyzer` is different from the index `analyzer`. This raises issues with the `_all` field when the `index.analysis.analyzer.default_search` is set, since it automatically makes the `search_analyzer` different from the index `analyzer`. Then there are exceptions since we expect the `_all` configuration to be empty on 6.0 indices. Closes #26136
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Aug 14, 2017
* master: (30 commits) Rewrite range queries with open bounds to exists query (elastic#26160) Fix eclipse compilation problem (elastic#26170) Epoch millis and second formats parse float implicitly (Closes elastic#14641) (elastic#26119) fix SplitProcessor targetField test (elastic#26178) Fixed typo in README.textile (elastic#26168) Fix incorrect class name in deleteByQuery docs (elastic#26151) Move more token filters to analysis-common module reindex: automatically choose the number of slices (elastic#26030) Fix serialization of the `_all` field. (elastic#26143) percolator: Hint what clauses are important in a conjunction query based on fields Remove unused Netty-related settings (elastic#26161) Remove SimpleQueryStringIT#testPhraseQueryOnFieldWithNoPositions. Tests: reenable ShardReduceIT#testIpRange. Allow `ClusterState.Custom` to be created on initial cluster states (elastic#26144) Teach the build about betas and rcs (elastic#26066) Fix wrong header level inner hits: Unfiltered nested source should keep its full path Document how to import Lucene Snapshot libs when elasticsearch clients (elastic#26113) Use `global_ordinals_hash` execution mode when sorting by sub aggregations. (elastic#26014) Make the README use a single type in examples. (elastic#26098) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we only serialize analyzers if the index analyzer is not the
defaultanalyzer or if thesearch_analyzeris different from the indexanalyzer. This raises issues with the_allfield when theindex.analysis.analyzer.default_searchis set, since it automatically makesthe
search_analyzerdifferent from the indexanalyzer. Then there areexceptions since we expect the
_allconfiguration to be empty on 6.0 indices.Closes #26136