Place Edge browser userdata directory in metadata space of workspace

[HeikoKlare]

The userdata directory for the Edge browser is currently placed as an immediate child of the workspace directory (if existing), thus mixing up with actual projects in the workspace. With this change, the directory is placed in the metadata folder of the SWT bundle within the workspace.

See #2434 (comment)

[github-actions]

Test Results

 1 821 files  ±0   1 821 suites  ±0   1h 55m 25s ⏱️ + 5m 12s
 7 724 tests ±0   7 495 ✅  - 1  228 💤 ±0  1 ❌ +1 
24 333 runs  ±0  23 585 ✅  - 1  747 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit ec79aef. ± Comparison against base commit 1170414.

♻️ This comment has been updated with latest results.

[sratz]

Looks good in principle.

One more thought: Is this EBWebView directory platform-independet or could we potentially run into inconsistencies / problems in case Windows-on-ARM users migrate from win32.win32.x86_64 to win32.win32.aarch64 with the same workspace?

[HeikoKlare]

One more thought: Is this EBWebView directory platform-independet or could we potentially run into inconsistencies / problems in case Windows-on-ARM users migrate from win32.win32.x86_64 to win32.win32.aarch64 with the same workspace?

Interesting question/scenario. The EBWebView folder is placed inside the .metadata/.plugins/org.eclipse.swt folder of the workspace. So this is independent of the platform (architecture) and I would expect this to also work in case of a migration. Do you agree?

I am not sure whether the data within that folder allows for migration between different systems/architectures, but that issue would at least be independent of where the folder is placed.

[sratz]

Right, my thought was whether there is anything platform-specific inside that folder, and we should instead put it into the fragment directories
.metadata/.plugins/org.eclipse.swt.win32.win32.x86_64
.metadata/.plugins/org.eclipse.swt.win32.win32.aarch64

But that is probably overthinking the problem, since if we did not override this path and stick to the default path, it also would be a generic platform-independent directory.

So would the %AppData%\Local\Microsoft\Edge\User Data\ directory of a regular Edge browser for that matter.

Remaining question: Who is the 'owner' of that directory

• Is it org.eclipse.ui.workbench because here we make the decision of where to put the Edge cache?
• Is it org.eclipse.swt because SWT is what uses it?

[HeikoKlare]

Remaining question: Who is the 'owner' of that directory

• Is it org.eclipse.ui.workbench because here we make the decision of where to put the Edge cache?
• Is it org.eclipse.swt because SWT is what uses it?

I am not sure whether there is a "correct" answer in the sense that there is some agreement, convention or the like that indisputably determines where to place it. I would go with the latter open (in org.eclipse.swt), because SWT contains and operates the browser, so I consider the browser user data to be metadata belonging to SWT. Putting it in org.eclipse.ui.workbench would feel a bit more "random" to me, because you could probably actually find a different place (i.e., bundle) in Eclipse UI where the directory could be determined. But I have no strong opinion on this, so if someone has valid arguments for another option, I will glady adapt the PR.

[HeikoKlare]

Failing test already documented: #370