[Tests] Random failing ProgressContantsTest.testKeepOneProperty

[ktatavarthi]

org.eclipse.ui.tests.progress.ProgressContantsTest.testKeepOneProperty fails in the I-build I20220928-1800 on Windows and MacM1 with the below error

Only one finished job should be kept in view expected:<1> but was:<20>

junit.framework.AssertionFailedError: Only one finished job should be kept in view expected:<1> but was:<20>
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.failNotEquals(Assert.java:329)
at junit.framework.Assert.assertEquals(Assert.java:78)
at junit.framework.Assert.assertEquals(Assert.java:234)
at junit.framework.TestCase.assertEquals(TestCase.java:377)
at org.eclipse.ui.tests.progress.ProgressContantsTest.testKeepOneProperty(ProgressContantsTest.java:259) 

[jukzi]

i can reproduce this error locally

[jukzi]

i can still reproduce this error when reverting eclipse.platform to 149a08f (2022-09-05) - before the JobManager.join changes!

[jukzi]

i can still reproduce this error when reverting eclipse.platform.ui to 180c5b6 (2022-09-21) - before my ui changes.

[iloveeclipse]

Unfortunately I can't reproduce on Linux, may be that is Windows specific.

i can still reproduce this error when reverting eclipse.platform.ui to 180c5b6 (2022-09-21) - before my ui changes.

OK, so that could be unrelated. The problem is that there is no one looking on Windows test fails, because there are too many of them, so it could be even already in 4.25.

[jukzi]

I can not reproduce it every time. it fails only like every 2nd time. When i revert my "fix #307: Progress View sometimes shows short living jobs twice" (2022-09-01) it fails far less often - but still sometimes with the same error.

[jukzi]

it also fails with eclipse-platform/eclipse.platform#188

[jukzi]

That was a timing issue that became more visible by the changed timing behavior. In DetailedProgressViewer.remove(JobTreeElement...) doFindItem returned null even though the element was already added.

[HeikoKlare]

Test still fails randomly, see https://github.com/eclipse-platform/eclipse.platform.ui/pull/1148/checks?check_run_id=16996362086