-
Notifications
You must be signed in to change notification settings - Fork 227
Set Edge data directory to workspace on Windows #2434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Edge data directory to workspace on Windows #2434
Conversation
Test Results 1 821 files ±0 1 821 suites ±0 1h 50m 21s ⏱️ + 2m 23s For more details on these failures, see this check. Results for commit adb78fa. ± Comparison against base commit 4fbbe1b. ♻️ This comment has been updated with latest results. |
2831958
to
3373da8
Compare
3373da8
to
c277967
Compare
c277967
to
497f830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the data key with the proper value added to SWT via:
I've restricted the additional data to Windows and added proper handling for workspace-free applications (see eclipse-platform/eclipse.platform.swt#1548 (comment)). I've also simplified the retrieval of the workspace directory path string using more "proper" conversion instead of toString-conversions.
@fedejeanne can you have a look please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeikoKlare the code looks fine. I only have 2 nit-picks and one question/suggestion regarding relative locations (if that's even a thing).
If the question is irrelevant then please consider this PR approved on my account :-)
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/Workbench.java
Outdated
Show resolved
Hide resolved
497f830
to
61a5b9f
Compare
This contributes to adding the workspace address to the display data on workbench initialization as the data directory used by Edge browser. Contributes to eclipse-platform/eclipse.platform.swt#1013
61a5b9f
to
adb78fa
Compare
Failing test is unrelated and documented: #195 |
With this change we now have a directory named
Should we maybe put this into a separate
Or move it into the plugin-specific instance-scoped directory?
|
That seems to be a proper place for this folder. Makes sense to move it there instead of having it placed directly in the workspace. Proposal: #2469 |
This contributes to adding the workspace address to the display data on the initilization of the workbench. This contribution allows further SWT components to utilize this information.
Contributes to eclipse-platform/eclipse.platform.swt#1013