IIS: Identify if a request has a body #25381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jkotalik
reviewed
Aug 28, 2020
src/Servers/IIS/IIS/test/Common.FunctionalTests/Inprocess/Http2Tests.cs
Outdated
Show resolved
Hide resolved
jkotalik
reviewed
Aug 28, 2020
jkotalik
approved these changes
Aug 28, 2020
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
halter73
reviewed
Sep 3, 2020
| namespace Microsoft.AspNetCore.Server.IIS.FunctionalTests.InProcess | ||
| { | ||
| [Collection(PublishedSitesCollection.Name)] | ||
| public class Http2Tests : IISFunctionalTestBase |
Member
There was a problem hiding this comment.
Are there any HTTP/1.x tests for RequestCanHaveBody?
halter73
reviewed
Sep 3, 2020
Member
Author
|
I'm struggling with the IIS test failures. It only fails in IIS, not express, and only on the CI. It seems to get back a 200 response with no body when we're expecting a body to be echo'd. I'm going to try updating the CI agents. I know we're using obsolete versions of Win10. #25627 |
Member
Author
|
@Pilchie please merge for rc2. |
Member
|
Approved for .NET 5 RC2. |
NTaylorMullen
pushed a commit
that referenced
this pull request
Sep 12, 2020
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24175. This is the IIS portion of the feature. IIS is easy because Http.Sys adds a fake Transfer-Encoding: chunked header even for HTTP/2 requests.