Skip to content

Conversation

@dotnet-maestro-bot
Copy link
Contributor

I detected changes in the release/5.0 branch which have not been merged yet to release/5.0-rc2. I'm a robot and am configured to help you automatically keep release/5.0-rc2 up to date, so I've opened this PR.

This PR merges commits made on release/5.0 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout release/5.0
git pull --ff-only
git checkout release/5.0-rc2
git pull --ff-only
git merge --no-ff release/5.0

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-release/5.0-rc2
or if you are using SSH
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-release/5.0-rc2

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/release/5.0-to-release/5.0-rc2'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/release/5.0-to-release/5.0-rc2 release/5.0-rc2
git pull https://github.com/dotnet-maestro-bot/AspNetCore merge/release/5.0-to-release/5.0-rc2
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-release/5.0-rc2
or if you are using SSH
git checkout -b merge/release/5.0-to-release/5.0-rc2 release/5.0-rc2
git pull [email protected]:dotnet-maestro-bot/AspNetCore merge/release/5.0-to-release/5.0-rc2
(make changes)
git commit -m "Updated PR with my changes"
git push [email protected]:dotnet-maestro-bot/AspNetCore HEAD:merge/release/5.0-to-release/5.0-rc2

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

Tratcher and others added 2 commits September 11, 2020 11:40
Fix MSB4109 error when the Microsoft.Extensions.ApiDescription.Server NuGet package is installed.
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Merge Forward ⏩ labels Sep 14, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving branch merge.

@ghost ghost added auto-merge tell-mode Indicates a PR which is being merged during tell-mode labels Sep 14, 2020
@ghost
Copy link

ghost commented Sep 14, 2020

Hello @msftbot[bot]!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Tratcher
Copy link
Member

Oh, @Pilchie the IIS change was accidentally merged into release/5.0 instead of 5.0-rc2.

@Tratcher Tratcher self-assigned this Sep 14, 2020
@ghost
Copy link

ghost commented Sep 14, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

1 similar comment
@ghost
Copy link

ghost commented Sep 14, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

@Pilchie
Copy link
Member

Pilchie commented Sep 14, 2020

@Tratcher - which IIS change?

@Tratcher
Copy link
Member

#25381

@ghost
Copy link

ghost commented Sep 14, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

@Tratcher
Copy link
Member

Ready to merge, and this already has tactics approval.

@Pilchie Pilchie merged commit e3a52ee into dotnet:release/5.0-rc2 Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode Type: Merge Forward ⏩

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants