Skip to content

Conversation

@Tratcher
Copy link
Member

@Tratcher Tratcher commented Sep 4, 2020

Let's see how well we work on new windows versions...

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 4, 2020
@Tratcher Tratcher self-assigned this Sep 4, 2020
Enable helix on PRs for testing 20h1
Comment on lines 2 to 5
pr: none
# Run PR validation on all branches
pr:
autoCancel: true
branches:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Revert

@Tratcher
Copy link
Member Author

Tratcher commented Sep 4, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit works for me. Careful w/ "green" requirements though -- failures in the aspnetcore-helix-matrix pipeline won't prevent merging and blocked labels are just a hint to the user 😺

@Tratcher
Copy link
Member Author

Tratcher commented Sep 5, 2020

Hmm, Windows.10.Amd64.Server20H1.Open timed out. Apparently it needs more capacity.

@Tratcher
Copy link
Member Author

Tratcher commented Sep 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Tratcher
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Tratcher
Copy link
Member Author

Skipped one set of tests:
#25768

@Tratcher
Copy link
Member Author

Windows.10.Amd64.Server20H1.Open is now passing with the one skipped diagnostics project. I've reverted the change to run the full helix pass on PRs. This should be ready to merge after a fresh CI run.

@Tratcher
Copy link
Member Author

@Pilchie Please approve/merge this test change for rc2.

@Pilchie Pilchie added this to the 5.0.0-rc2 milestone Sep 10, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 11, 2020

I'm going to force merge this, given that it shouldn't affect these tests.

@Pilchie Pilchie merged commit 11b85eb into release/5.0-rc2 Sep 11, 2020
@Pilchie Pilchie deleted the tratcher/20h1 branch September 11, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants