Skip to content

Suppress baseline reference of Microsoft.AspNetCore.SpaServices #25371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Suppress baseline reference of Microsoft.AspNetCore.SpaServices #25371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,11 @@
<InternalsVisibleTo Include="Microsoft.AspNetCode.SpaServices.Extensions.Tests" />
</ItemGroup>

<ItemGroup Condition=" '$(AspNetCoreMajorMinorVersion)' == '5.0' ">
<!--
Dependency (now in shared Fx and a transitive ref for netstandard2.x) was removed in 5.0. Suppression can be
Copy link
Contributor

@dougbu dougbu Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the unintentional conflict between my #25227 and @pranavkm's #25290. But, this comment is incorrect. Should just say the Microsoft.AspNetCore.SpaServices package doesn't exist anymore, I think. Please do a follow up PR so that we don't get confused down the road.

Copy link
Contributor Author

@JunTaoLuo JunTaoLuo Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit 44175ed

Copy link
Contributor

@dougbu dougbu Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JunTaoLuo. What PR was / is that commit part of❔

removed after 5.0 RTM is released.
-->
<SuppressBaselineReference Include="Microsoft.AspNetCore.SpaServices" />
</ItemGroup>
</Project>