Skip to content

Suppress baseline reference of Microsoft.AspNetCore.SpaServices #25371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2020
Merged

Suppress baseline reference of Microsoft.AspNetCore.SpaServices #25371

merged 1 commit into from
Aug 28, 2020

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Aug 28, 2020 •
edited
Loading

This fixes the error:

error BUILD001: Reference to 'Microsoft.AspNetCore.SpaServices' was removed since the last stable release of this package. This could be a breaking change. See docs/ReferenceResolution.md for instructions on how to update changes to references or suppress this warning if the error was intentional.

The build break was caused by the concurrent merging of #25290 and #25227. The baseline checks were fixed which flagged the missing baseline reference that was removed in #25290. This is an unfortunate timing issue and both PRs by themselves would have passed all CI checks. The combination of the two broke the build.

This is an FYI only, I'm merging immediately to fix build.

@JunTaoLuo JunTaoLuo requested a review from Tratcher as a code owner August 28, 2020 19:12
@ghost ghost added the area-middleware label Aug 28, 2020
@JunTaoLuo JunTaoLuo merged commit e272a00 into release/5.0 Aug 28, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/add-baseline-suppression branch August 28, 2020 19:12
dougbu
dougbu reviewed Aug 28, 2020
View reviewed changes
src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj

<ItemGroup Condition=" '$(AspNetCoreMajorMinorVersion)' == '5.0' ">
<!--
Dependency (now in shared Fx and a transitive ref for netstandard2.x) was removed in 5.0. Suppression can be
Copy link
Contributor

@dougbu dougbu Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the unintentional conflict between my #25227 and @pranavkm's #25290. But, this comment is incorrect. Should just say the Microsoft.AspNetCore.SpaServices package doesn't exist anymore, I think. Please do a follow up PR so that we don't get confused down the road.

Copy link
Contributor Author

@JunTaoLuo JunTaoLuo Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit 44175ed

Copy link
Contributor

@dougbu dougbu Aug 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JunTaoLuo. What PR was / is that commit part of❔

@amcasey amcasey added the area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tratcher Tratcher Awaiting requested review from Tratcher Tratcher is a code owner

1 more reviewer

@dougbu dougbu dougbu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-middleware Includes: URL rewrite, redirect, response cache/compression, session, and other general middlewares

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JunTaoLuo @dougbu @amcasey