Skip to content

Conversation

@pranavkm
Copy link
Contributor

Follow up to #24912.
Not shipping NodeServices isn't enough since it's referenced by SpaServices. This PR removes the two packages
that were announced to be removed in 5.0

Follow up to #24912.
Not shipping NodeServices isn't enough since it's referenced by SpaServices. This PR removes the two packages
that were announced to be removed in 5.0
@pranavkm pranavkm marked this pull request as ready for review August 26, 2020 21:25
@pranavkm pranavkm requested a review from Tratcher as a code owner August 26, 2020 21:25
@pranavkm pranavkm requested a review from javiercn August 26, 2020 21:25
@pranavkm pranavkm added this to the 5.0.0-rc1 milestone Aug 26, 2020
@Pilchie Pilchie added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Aug 27, 2020
@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Aug 28, 2020
@Pilchie
Copy link
Member

Pilchie commented Aug 28, 2020

Approved for RC1.

@mkArtakMSFT mkArtakMSFT merged commit b51d2fe into release/5.0 Aug 28, 2020
@mkArtakMSFT mkArtakMSFT deleted the prkrishn/remove-spaservices branch August 28, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-spa Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Microsoft.AspNetCore.SpaServices.Extensions dependency on Microsoft.AspNetCore.SpaServices

5 participants