[release/5.0] Correct baseline checks #25227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
requested review from
a team,
BrennanConroy,
SteveSandersonMS,
Tratcher,
halter73 and
jkotalik
as code owners
dougbu
added
area-infrastructure
Contributor
Author
|
Code owners: Changes to your |
dougbu
force-pushed
the
dougbu/fixup.baselines.5.0
branch
from
b914a61 to
493e9ae
Compare
- mostly duplicates #25217 - update `BaselineGenerator` to produce baselines useful in 6.0 (too) - update Baseline.Designer.props using new generator (matching 3.1.7 release) - always suppress references expressed only in `*.nuspec` files - needed even in servicing builds - restore warning and errors about removed references (new for 5.0) - adjust exclusions to handle `@(_ProjectReferenceByAssemblyName)` removal nit: do not generate empty `<ItemGroup />` elements
- remove out-of-date `@(SuppressBaselineReference)` items - either 3.1.7 baselines we're using don't include reference or still using package - fix some comments and `Condition` attributes to make remainder easy to find - add missing `@(SuppressBaselineReference)` items
- update `BaselineGenerator` to get it working in 5.0 for realz
dougbu
force-pushed
the
dougbu/fixup.baselines.5.0
branch
from
493e9ae to
cf454a9
Compare
Contributor
Author
|
/ping reviewers. This is passing validations and ready for review |
wtgodbe
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[release/5.0] Correct baseline checks
BaselineGeneratorto produce baselines useful in 6.0 (too)*.nuspecfiles@(_ProjectReferenceByAssemblyName)removalnit: do not generate empty
<ItemGroup />elementsCorrect
@(SuppressBaselineReference)items@(SuppressBaselineReference)itemsConditionattributes to make remainder easy to find@(SuppressBaselineReference)items