[Mono.Posix] Sign with mono.pub
#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign `Mono.Posix.dll` with `mono.pub`, not with `product.snk`. This is required because the existing Xamarin.Android SDK signs `Mono.Posix.dll` with `mono.pub`, so the same signing key needs to be used so that existing assembly references are not broken because a new/different signing key is used.
radical
pushed a commit
that referenced
this pull request
May 8, 2018
We update possibly-enumified members after loading XML metadata, but currently we iterate everything we loaded including managed references. That's waste of processing, so don't do that. (Also reduced attempts to process base types, but they did not actually happen anyways. The relevant code is slightly simplified.)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jan 30, 2020
Changes: dotnet/android-tools@9f4ed4b...bfb66f3 * dotnet/android-tools@bfb66f3: Update to sdk-style csproj and netstandard2.0. (dotnet#78)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jan 30, 2020
Changes: dotnet/android-tools@9f4ed4b...bfb66f3 * dotnet/android-tools@bfb66f3: Update to sdk-style csproj and netstandard2.0. (dotnet#78)
jonpryor
added a commit
that referenced
this pull request
Jan 31, 2020
Changes: dotnet/android-tools@9f4ed4b...bfb66f3 * dotnet/android-tools@bfb66f3: Update to sdk-style csproj and netstandard2.0. (#78)
jonpryor
pushed a commit
that referenced
this pull request
Feb 18, 2021
Changes: dotnet/android-libzipsharp@1.0.20...1.0.22 * dotnet/android-libzipsharp@9f563dd: Add a test which changes the CompressionMethod of an item (#78) * dotnet/android-libzipsharp@3b610c9: Try actually running the tests under .net core (#77) * dotnet/android-libzipsharp@03cd66b: Archive the SignList.xml * dotnet/android-libzipsharp@8afe791: Add the signListPath parameter * dotnet/android-libzipsharp@ed5585c: Add SignList.xml for signing * dotnet/android-libzipsharp@2ab6943: Add a build_windows.bat file to make it easier to build on windows (#75) * … * dotnet/android-libzipsharp@9dca4fb: Initial commit of localisation * dotnet/android-libzipsharp@668babc: Add Unit Test for setting file permissions on extraction. * dotnet/android-libzipsharp@8f2053c: Build on Windows again (#71)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign
Mono.Posix.dllwithmono.pub, not withproduct.snk.This is required because the existing Xamarin.Android SDK signs
Mono.Posix.dllwithmono.pub, so the same signing key needs to beused so that existing assembly references are not broken because a
new/different signing key is used.